fix(orchestarator):Disable abort when workflow execution does not exist

Signed-off-by: Lior Soffer <[email protected]>

Author: LiorSoffer

workspaces/orchestrator/.changeset/cool-cats-explain.md

@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-orchestrator': patch
+---
+
+Disable abort when workflow execution does not exist

workspaces/orchestrator/plugins/orchestrator/src/components/InfoDialog.tsx

@@ -1,5 +1,5 @@
 /*
- * Copyright 2024 The Backstage Authors
+ * Copyright Red Hat, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import React, { forwardRef, ForwardRefRenderFunction } from 'react';
 
 import {
@@ -45,7 +46,13 @@ const useStyles = makeStyles(_theme => ({
   },
   dialogActions: {
     justifyContent: 'flex-start',
-    paddingLeft: _theme.spacing(2),
+    paddingLeft: _theme.spacing(3),
+    paddingBottom: _theme.spacing(2),
+  },
+  title: {
+    position: 'absolute',
+    left: 20,
+    top: 20,
   },
 }));
 
@@ -60,7 +67,9 @@ export const RefForwardingInfoDialog: ForwardRefRenderFunction<
     <Dialog onClose={_ => onClose} open={open} ref={forwardedRef}>
       <DialogTitle>
         <Box>
-          <Typography variant="h5">{title}</Typography>
+          <Typography className={classes.title} variant="h5">
+            {title}
+          </Typography>
           <IconButton
             className={classes.closeBtn}
             aria-label="close"

workspaces/orchestrator/plugins/orchestrator/src/components/WorkflowInstancePage.tsx

@@ -42,6 +42,7 @@ import Snackbar from '@material-ui/core/Snackbar';
 import { createStyles, makeStyles, Theme } from '@material-ui/core/styles';
 import CloseIcon from '@material-ui/icons/Close';
 import ErrorIcon from '@material-ui/icons/Error';
+import { AlertTitle } from '@material-ui/lab';
 import Alert from '@material-ui/lab/Alert';
 import ArrowDropDown from '@mui/icons-material/ArrowDropDown';
 import StartIcon from '@mui/icons-material/Start';
@@ -70,36 +71,89 @@ import { WorkflowInstancePageContent } from './WorkflowInstancePageContent';
 const useStyles = makeStyles((theme: Theme) =>
   createStyles({
     abortButton: {
-      backgroundColor: theme.palette.error.main,
-      color: theme.palette.getContrastText(theme.palette.error.main),
+      backgroundColor: theme.palette.error.dark,
+      color: theme.palette.getContrastText(theme.palette.error.dark),
       '&:hover': {
         backgroundColor: theme.palette.error.dark,
+        filter: 'brightness(90%)',
       },
     },
+    modalText: {
+      fontSize: '1.1rem',
+    },
+    errorColor: {
+      color: theme.palette.error.dark,
+    },
   }),
 );
 
 export type AbortConfirmationDialogActionsProps = {
   handleSubmit: () => void;
   handleCancel: () => void;
+  isAborting: boolean;
+  canAbort: boolean;
 };
 
-const AbortConfirmationDialogContent = () => (
-  <div>
-    <b>
-      Are you sure you want to abort this workflow run? <br /> <br />
-      Aborting will stop all in-progress and pending steps immediately. Any
-      incomplete tasks will not be saved.
-    </b>
-  </div>
-);
+const AbortConfirmationDialogContent = ({
+  canAbort,
+}: {
+  canAbort: boolean;
+}) => {
+  const classes = useStyles();
+  return (
+    <div>
+      <p className={classes.modalText}>
+        Are you sure you want to abort this workflow run? <br /> <br />
+        Aborting will stop all in-progress and pending steps immediately. Any
+        incomplete tasks will not be saved.
+      </p>
+      {!canAbort && (
+        <Box sx={{ width: '100%' }}>
+          <Alert severity="info">
+            <AlertTitle>Run completed</AlertTitle>
+            It is not possible to abort the run as it has already been
+            completed.
+          </Alert>
+        </Box>
+      )}
+    </div>
+  );
+};
+
+const AbortConfirmationDialogActions = (
+  props: AbortConfirmationDialogActionsProps,
+) => {
+  const classes = useStyles();
+  return (
+    <>
+      <Button
+        onClick={props.handleSubmit}
+        variant="contained"
+        className={classes.abortButton}
+        startIcon={props.isAborting ? <CircularProgress size="1rem" /> : null}
+        disabled={props.isAborting || !props.canAbort}
+      >
+        {' '}
+        Abort
+      </Button>
+      <Button
+        onClick={props.handleCancel}
+        variant="outlined"
+        color="primary"
+        disabled={props.isAborting}
+      >
+        {' '}
+        Cancel
+      </Button>
+    </>
+  );
+};
 
 export const WorkflowInstancePage = ({
   instanceId,
 }: {
   instanceId?: string;
 }) => {
-  const classes = useStyles();
   const navigate = useNavigate();
   const orchestratorApi = useApi(orchestratorApiRef);
   const executeWorkflowLink = useRouteRef(executeWorkflowRouteRef);
@@ -125,32 +179,6 @@ export const WorkflowInstancePage = ({
     setIsRerunSnackbarOpen(false);
   };
 
-  const AbortConfirmationDialogActions = (
-    props: AbortConfirmationDialogActionsProps,
-  ) => (
-    <>
-      <Button
-        onClick={props.handleSubmit}
-        variant="contained"
-        className={classes.abortButton}
-        startIcon={isAborting ? <CircularProgress size="1rem" /> : null}
-        disabled={isAborting}
-      >
-        {' '}
-        Abort
-      </Button>
-      <Button
-        onClick={props.handleCancel}
-        variant="outlined"
-        color="primary"
-        disabled={isAborting}
-      >
-        {' '}
-        Cancel
-      </Button>
-    </>
-  );
-
   const fetchInstance = React.useCallback(async () => {
     if (!instanceId && !queryInstanceId) {
       return undefined;
@@ -266,6 +294,8 @@ export const WorkflowInstancePage = ({
     else if (option === 'retrigger') handleRetrigger();
   };
 
+  const classes = useStyles();
+
   return (
     <BaseOrchestratorPage
       title={value?.instance.id}
@@ -280,8 +310,11 @@ export const WorkflowInstancePage = ({
             <InfoDialog
               title={
                 <Box display="flex" alignItems="center">
-                  <ErrorIcon color="error" style={{ marginRight: 8 }} />
-                  <b>Abort workflow</b>
+                  <ErrorIcon
+                    className={classes.errorColor}
+                    style={{ marginRight: 8 }}
+                  />
+                  <b>Abort workflow run?</b>
                 </Box>
               }
               onClose={toggleAbortConfirmationDialog}
@@ -290,9 +323,11 @@ export const WorkflowInstancePage = ({
                 <AbortConfirmationDialogActions
                   handleCancel={toggleAbortConfirmationDialog}
                   handleSubmit={handleAbort}
+                  isAborting={isAborting}
+                  canAbort={canAbort}
                 />
               }
-              children={<AbortConfirmationDialogContent />}
+              children={<AbortConfirmationDialogContent canAbort={canAbort} />}
             />
             <Grid container item justifyContent="flex-end" spacing={1}>
               <Grid item>