Skip to content

Commit 5a0019a

Browse files
authored
fix: parse filename from response header add annotation (#401)
1 parent 962e48f commit 5a0019a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pkg/net/http.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -331,11 +331,12 @@ func DetectSizeWithRoundTripper(targetURL, output string, showProgress, noProxy,
331331
return
332332
}
333333

334-
// ParseSuggestedFilename parse the filename from resp header
334+
// ParseSuggestedFilename parse the filename from resp header,More details from https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition
335335
func ParseSuggestedFilename(header http.Header, filepath string) (filename string) {
336336
if disposition, ok := header["Content-Disposition"]; ok && len(disposition) >= 1 {
337-
if index := strings.LastIndex(disposition[0], `filename="`); index != -1 {
338-
filename = disposition[0][index+len(`filename="`):]
337+
if index := strings.LastIndex(disposition[0], `filename=`); index != -1 {
338+
filename = disposition[0][index+len(`filename=`):]
339+
filename = strings.TrimPrefix(filename, `"`)
339340
filename = strings.TrimSuffix(filename, `"`)
340341
if filename == filepath {
341342
filename = ""

0 commit comments

Comments
 (0)