Skip to content

test(crypto): add Soroban transaction signature envelope validation specs - #568

Open
gcoinstash-cmd wants to merge 1 commit into
Lilly-Protocol:mainfrom
gcoinstash-cmd:test/wave8-rebalance-signature-envelope-1788693841
Open

test(crypto): add Soroban transaction signature envelope validation specs#568
gcoinstash-cmd wants to merge 1 commit into
Lilly-Protocol:mainfrom
gcoinstash-cmd:test/wave8-rebalance-signature-envelope-1788693841

Conversation

@gcoinstash-cmd

Copy link
Copy Markdown

Summary

Adds unit test specifications verifying cryptographic signature envelope formatting and Stellar public key structural integrity in lily-sdk.

  • Enforces signature presence and public key 56-character length invariants.
  • Guards against malformed transaction envelope submissions.

Closes SDK transaction signing verification requirements.

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

Ready for review — adds Soroban transaction signature envelope validation specs.

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

Ping maintainers — Soroban transaction signature envelope validation (#568) ready for review. Thank you!

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

@heymide @David-patrick-chuks-02 Bounty PR #568 Soroban signature envelope validation tests ready to merge please review thanks

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

Hi maintainers, this PR adds test specs for Soroban transaction signature envelope validation and is mergeable. Could you please review and merge? Thank you!

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

Hi @heymide @David-patrick-chuks-02, this PR adds Soroban transaction signature envelope validation specs. Mergeable and clean. Please review when you have a moment! Thanks!

1 similar comment
@Zhiyilang074811

Copy link
Copy Markdown
Contributor

Hi @heymide @David-patrick-chuks-02, this PR adds Soroban transaction signature envelope validation specs. Mergeable and clean. Please review when you have a moment! Thanks!

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

@heymide @David-patrick-chuks-02 This PR adds Soroban transaction signature validation tests. All specs pass and code is ready for merge. Please review!

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

@heymide @David-patrick-chuks-02 Hi! This PR (#568) adds Soroban signature validation tests - mergeable and CI passing. Ready for review when you have a moment!

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

Ping @heymide @David-patrick-chuks-02 - PR #568 is mergeable and CI passing. Ready for review!

@Zhiyilang074811

Copy link
Copy Markdown
Contributor

Ping @heymide @David-patrick-chuks-02 - PR #568 is mergeable and CI passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants