Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging_mode (on_step or on_epoch) available to loggers #20502

Open
SiddhantSadangi opened this issue Dec 17, 2024 · 4 comments
Open

Make logging_mode (on_step or on_epoch) available to loggers #20502

SiddhantSadangi opened this issue Dec 17, 2024 · 4 comments
Labels
feature Is an improvement or enhancement

Comments

@SiddhantSadangi
Copy link
Contributor

SiddhantSadangi commented Dec 17, 2024

Description & Motivation

Lightning lets you log on_step, or on_epoch. However, even when using on_epoch, the global step is logged on the x-axis, not the epoch number.

Loggers can manually extract epoch from the logged metrics and pass that as the step. However, this would break on_step logging.

Making the logging mode for a logging call available would let loggers conditionally use either the global_step or current_epoch as the step for that particular metric.

Pitch

No response

Alternatives

No response

Additional context

No response

cc @Borda

@SiddhantSadangi SiddhantSadangi added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Dec 17, 2024
@lantiga
Copy link
Collaborator

lantiga commented Jan 6, 2025

Hey @SiddhantSadangi, this is very reasonable. Would you like to send a PR?
The key thing to ensure is that we don't break the behavior of existing loggers.

@lantiga lantiga removed the needs triage Waiting to be triaged by maintainers label Jan 6, 2025
@SiddhantSadangi
Copy link
Contributor Author

Hey @SiddhantSadangi, this is very reasonable. Would you like to send a PR?

I can start working on it once I've some bandwidth. It can take a couple of months, though, due to present commitments :(

@lantiga
Copy link
Collaborator

lantiga commented Jan 6, 2025

That would be great @SiddhantSadangi! Of course, let's circle back in a couple of weeks and see where you are in terms of bandwidth.

BTW anyone interested in helping?

@SiddhantSadangi
Copy link
Contributor Author

I'll share this thread with a few Neptune users who had initially requested this. Meanwhile, can we add the Help wanted label here to invite contributions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants