Add windows skips for Fabric

Author: awaelchli

tests/tests_fabric/plugins/precision/test_amp_integration.py

@@ -12,10 +12,13 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 """Integration tests for Automatic Mixed Precision (AMP) training."""
+import sys
+
 import pytest
 import torch
 import torch.nn as nn
 from lightning.fabric import Fabric, seed_everything
+from lightning.fabric.utilities.imports import _TORCH_GREATER_EQUAL_2_2
 
 from tests_fabric.helpers.runif import RunIf
 
@@ -37,6 +40,10 @@ def forward(self, x):
         return output
 
 
+@pytest.mark.skipif(
+    # https://github.com/pytorch/pytorch/issues/116056
+    sys.platform == "win32" and _TORCH_GREATER_EQUAL_2_2, reason="Windows + DDP issue in PyTorch 2.2"
+)
 @pytest.mark.parametrize(
     ("accelerator", "precision", "expected_dtype"),
     [

tests/tests_fabric/strategies/launchers/test_multiprocessing_integration.py

@@ -11,10 +11,13 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+import sys
+
 import pytest
 import torch
 import torch.nn as nn
 from lightning.fabric import Fabric
+from lightning.fabric.utilities.imports import _TORCH_GREATER_EQUAL_2_2
 
 from tests_fabric.helpers.runif import RunIf
 
@@ -28,6 +31,10 @@ def __init__(self):
         self.register_buffer("buffer", torch.ones(3))
 
 
+@pytest.mark.skipif(
+    # https://github.com/pytorch/pytorch/issues/116056
+    sys.platform == "win32" and _TORCH_GREATER_EQUAL_2_2, reason="Windows + DDP issue in PyTorch 2.2"
+)
 @pytest.mark.parametrize("strategy", ["ddp_spawn", pytest.param("ddp_fork", marks=RunIf(skip_windows=True))])
 def test_memory_sharing_disabled(strategy):
     """Test that the multiprocessing launcher disables memory sharing on model parameters and buffers to avoid race

tests/tests_fabric/strategies/test_ddp_integration.py

@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+import sys
 from copy import deepcopy
 
 import pytest
@@ -19,8 +20,13 @@
 
 from tests_fabric.helpers.runif import RunIf
 from tests_fabric.strategies.test_single_device import _run_test_clip_gradients
+from lightning.fabric.utilities.imports import _TORCH_GREATER_EQUAL_2_2
 
 
+@pytest.mark.skipif(
+    # https://github.com/pytorch/pytorch/issues/116056
+    sys.platform == "win32" and _TORCH_GREATER_EQUAL_2_2, reason="Windows + DDP issue in PyTorch 2.2"
+)
 @pytest.mark.parametrize(
     "accelerator",
     [

tests/tests_fabric/utilities/test_distributed.py

@@ -1,5 +1,6 @@
 import functools
 import os
+import sys
 from functools import partial
 from pathlib import Path
 from unittest import mock
@@ -17,6 +18,7 @@
     _sync_ddp,
     is_shared_filesystem,
 )
+from lightning.fabric.utilities.imports import _TORCH_GREATER_EQUAL_2_2
 
 from tests_fabric.helpers.runif import RunIf
 
@@ -118,6 +120,10 @@ def test_collective_operations(devices, process):
     spawn_launch(process, devices)
 
 
+@pytest.mark.skipif(
+    # https://github.com/pytorch/pytorch/issues/116056
+    sys.platform == "win32" and _TORCH_GREATER_EQUAL_2_2,reason="Windows + DDP issue in PyTorch 2.2"
+)
 @pytest.mark.flaky(reruns=3)  # flaky with "process 0 terminated with signal SIGABRT" (GLOO)
 def test_is_shared_filesystem(tmp_path, monkeypatch):
     # In the non-distributed case, every location is interpreted as 'shared'

tests/tests_fabric/utilities/test_spike.py

@@ -4,6 +4,7 @@
 import pytest
 import torch
 from lightning.fabric import Fabric
+from lightning.fabric.utilities.imports import _TORCH_GREATER_EQUAL_2_2
 from lightning.fabric.utilities.spike import _TORCHMETRICS_GREATER_EQUAL_1_0_0, SpikeDetection, TrainingSpikeException
 
 
@@ -28,6 +29,10 @@ def spike_detection_test(fabric, global_rank_spike, spike_value, should_raise):
             )
 
 
+@pytest.mark.skipif(
+    # https://github.com/pytorch/pytorch/issues/116056
+    sys.platform == "win32" and _TORCH_GREATER_EQUAL_2_2,reason="Windows + DDP issue in PyTorch 2.2"
+)
 @pytest.mark.flaky(max_runs=3)
 @pytest.mark.parametrize(
     ("global_rank_spike", "num_devices", "spike_value", "finite_only"),