nodejs 20 support test

Author: CarlGao4

.github/workflows/build.yml

@@ -13,7 +13,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  EM_VERSION: 2.0.6
+  EM_VERSION: 3.1.74
   EM_CACHE_FOLDER: 'emsdk-cache'
   COMMIT_MSG: ${{ github.event.head_commit.message }}
 
@@ -28,7 +28,7 @@ jobs:
           submodules: true
       - uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: 20
       - uses: actions/cache@v3
         with:
           path: ${{env.EM_CACHE_FOLDER}}
@@ -95,7 +95,7 @@ jobs:
           submodules: false
       - uses: actions/setup-node@v1
         with:
-          node-version: 12
+          node-version: 20
 
       - name: Download webmscore package tarball
         uses: actions/download-artifact@v4

web/CMakeLists.txt

@@ -5,6 +5,10 @@ project(webmscore)
 
 set(CMAKE_INCLUDE_CURRENT_DIR ON)
 
+# Emscripten.cmake will disable the default CMake finders to avoid incompatible packages
+# But we are using all our own packages so we need to enable them again
+set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE BOTH)
+
 set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
@@ -73,7 +77,11 @@ set(CMAKE_CXX_FLAGS         "${CMAKE_CXX_FLAGS} -s USE_ZLIB=1")      # 1 = use z
 # set(CMAKE_CXX_FLAGS         "${CMAKE_CXX_FLAGS} -s USE_FREETYPE=1")  # 1 = use freetype from emscripten-ports
 set(CMAKE_CXX_FLAGS         "${CMAKE_CXX_FLAGS} -s USE_VORBIS=1")    # 1 = use vorbis from emscripten-ports
 set(CMAKE_CXX_FLAGS         "${CMAKE_CXX_FLAGS} -s USE_OGG=1")       # 1 = use ogg from emscripten-ports
-set(CMAKE_CXX_FLAGS         "${CMAKE_CXX_FLAGS} -s DEMANGLE_SUPPORT=1")
+
+# Only enable this when emcc version < 3.1.54 since it's deprecated
+if(EMSCRIPTEN_VERSION VERSION_LESS "3.1.54")
+    set(CMAKE_CXX_FLAGS         "${CMAKE_CXX_FLAGS} -s DEMANGLE_SUPPORT=1")
+endif()
 
 set(CMAKE_CXX_FLAGS_DEBUG   "-g4 -s ASSERTIONS=2 -s STACK_OVERFLOW_CHECK=2 -s SAFE_HEAP=1")
 set(CMAKE_CXX_FLAGS_RELEASE "-Oz -DNDEBUG -DQT_NO_DEBUG")

web/Makefile

@@ -1,39 +1,37 @@
 
-CPUS	  := $(shell getconf _NPROCESSORS_ONLN 2>/dev/null || getconf NPROCESSORS_ONLN 2>/dev/null || echo 1)
-MU_ROOT	  := $(dir ${CURDIR})
+CPUS      := $(shell getconf _NPROCESSORS_ONLN 2>/dev/null || getconf NPROCESSORS_ONLN 2>/dev/null || echo 1)
+MU_ROOT   := $(dir ${CURDIR})
 
 # EMBED_PRELOADS = "OFF"
 # BUILD_NUMBER   = $(shell git rev-parse --short=7 HEAD)
 
 # change path to include your Qt5 installation
-export CMAKE_PREFIX_PATH	=	../../build.qt5/5.15.2/wasm_32
+export CMAKE_PREFIX_PATH    =    ../../build.qt5/5.15.2/wasm_32
 
 # setup ccache
-export CCACHE_BASEDIR		=	${MU_ROOT}
-export CCACHE_DIR			=	${MU_ROOT}/.ccache
-export CCACHE_COMPRESS		=	true
+export CCACHE_BASEDIR       =    ${MU_ROOT}
+export CCACHE_DIR           =    ${MU_ROOT}/.ccache
+export CCACHE_COMPRESS      =    true
 
-export NODE_OPTIONS			=	--max_old_space_size=4096
+export NODE_OPTIONS         =    --max_old_space_size=4096
 
 release:
 	if test ! -d build.release; then mkdir build.release; fi; \
 	  cd build.release;                                        \
-	  emcmake cmake -DCMAKE_BUILD_TYPE=RELEASE	                \
+	  emcmake cmake -DCMAKE_BUILD_TYPE=RELEASE                  \
 	  -DEMBED_PRELOADS="${EMBED_PRELOADS}"                       \
-	  -DCMAKE_TOOLCHAIN_FILE="${CMAKE_TOOLCHAIN_FILE}"            \
-	  -DCMAKE_BUILD_NUMBER="${BUILD_NUMBER}" ..;                   \
-	  emmake make -j ${CPUS};                                       \
-	  mv ./webmscore.* ../../web-public;                             \
+	  -DCMAKE_BUILD_NUMBER="${BUILD_NUMBER}" ..;                  \
+	  emmake make -j ${CPUS};                                      \
+	  mv ./webmscore.* ../../web-public;                            \
 
 debug:
 	if test ! -d build.debug; then mkdir build.debug; fi; \
 	  cd build.debug;                                      \
-	  emcmake cmake -DCMAKE_BUILD_TYPE=DEBUG	            \
+	  emcmake cmake -DCMAKE_BUILD_TYPE=DEBUG                \
 	  -DEMBED_PRELOADS="${EMBED_PRELOADS}"                   \
-	  -DCMAKE_TOOLCHAIN_FILE="${CMAKE_TOOLCHAIN_FILE}"        \
-	  -DCMAKE_BUILD_NUMBER="${BUILD_NUMBER}" ..;               \
-	  emmake make -j ${CPUS};                                   \
-	  mv ./webmscore.* ../../web-public;                         \
+	  -DCMAKE_BUILD_NUMBER="${BUILD_NUMBER}" ..;              \
+	  emmake make -j ${CPUS};                                  \
+	  mv ./webmscore.* ../../web-public;                        \
 
 #
 # clean out of source build