ARRISEOS-48521 OCDM: protect against double-delete

There are some scenarios where OCDM::Deinitialize
seems to be run more than once in parallel (likely
on Thunder shutdown). The change protects against
double-release/use-after-free bugs.

Author: tomasz-karczewski-red

OpenCDMi/OCDM.cpp

@@ -109,6 +109,7 @@ namespace Plugin {
         ForceLinkingOfOpenCDM();
 		#endif
 
+        std::lock_guard<std::recursive_mutex> lock {_serviceInitMutex};
         string message;
 
         ASSERT(service != nullptr);
@@ -157,9 +158,12 @@ namespace Plugin {
 
     /*virtual*/ void OCDM::Deinitialize(PluginHost::IShell* service)
     {
+        std::lock_guard<std::recursive_mutex> lock {_serviceInitMutex};
         ASSERT(_service == service);
 
-        _service->Unregister(&_notification);
+        if (_service == nullptr) {
+            TRACE(Trace::Error, (_T("OCDM::Deinitialize called with null _service; will be skipped. %d"), __LINE__));
+        }
 
         if(_opencdmi != nullptr) {
 
@@ -169,7 +173,7 @@ namespace Plugin {
             }
 
             _opencdmi->Unregister(&_notification);
-            _opencdmi->Deinitialize(service);
+            _opencdmi->Deinitialize(_service);
             RPC::IRemoteConnection* connection(_service->RemoteConnection(_connectionId));
 
             UnregisterAll();
@@ -193,7 +197,7 @@ namespace Plugin {
             }
         }
 
-        PluginHost::ISubSystem* subSystem = service->SubSystems();
+        PluginHost::ISubSystem* subSystem = _service->SubSystems();
 
         if (subSystem != nullptr) {
             if(subSystem->IsActive(PluginHost::ISubSystem::DECRYPTION) == true) {

OpenCDMi/OCDM.h

@@ -20,6 +20,8 @@
 #ifndef __OPENCDMI_H
 #define __OPENCDMI_H
 
+#include <mutex>
+
 #include "Module.h"
 #include <interfaces/IContentDecryption.h>
 #include <interfaces/IMemory.h>
@@ -225,6 +227,7 @@ namespace Plugin {
         Exchange::IContentDecryption* _opencdmi;
         Exchange::IMemory* _memory;
         Core::Sink<Notification> _notification;
+        std::recursive_mutex _serviceInitMutex;
     };
 } //namespace Plugin