Skip to content

ARRISAPOL-3614 wpe: fix in GstState handling #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tomasz-karczewski-red wants to merge 1 commit into
base: lgi-wpe-2.38-23Q4
Choose a base branch
from
Draft

ARRISAPOL-3614 wpe: fix in GstState handling #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,10 @@ bool MediaPlayerPrivateGStreamer::changePipelineState(GstState newState)
GstState currentState, pending;

gst_element_get_state(m_pipeline.get(), &currentState, &pending, 0);
if (currentState == newState || pending == newState) {

// the pipeline can be in the process of switching to another state (pending != GST_STATE_VOID_PENDING)
// in such case we should apply newState even if at the moment it is equal to currentState (this will soon change)
if ( (currentState == newState && pending == GST_STATE_VOID_PENDING) || pending == newState) {
GST_DEBUG_OBJECT(pipeline(), "Rejected state change to %s from %s with %s pending", gst_element_state_get_name(newState),
gst_element_state_get_name(currentState), gst_element_state_get_name(pending));
return true;
Expand Down