Skip to content

[ONEM-33645]: Setting PlaybackRate=0 does not pause video in WPE2.38 #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suresh-khurdiya-epam wants to merge 2 commits into
base: wpe-2.38
Choose a base branch
from
Open

[ONEM-33645]: Setting PlaybackRate=0 does not pause video in WPE2.38 #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2df740
revert of loading failure logs are not seen in systemconsole(journalctl)
suresh-khurdiya-epam Nov 29, 2023
a6576de
[ONEM-33645]: Setting PlaybackRate=0 does not pause video in WPE2.38
suresh-khurdiya-epam Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,12 @@ void MediaPlayerPrivateGStreamer::setRate(float rate)
m_playbackRatePausedState = PlaybackRatePausedState::RatePaused;
updateStates();
}
if (m_currentState == GST_STATE_PLAYING && m_playbackRatePausedState != PlaybackRatePausedState::RatePaused) {
GST_INFO_OBJECT(pipeline(), "Pausing stream because of zero playback rate in setRate");
m_playbackRatePausedState = PlaybackRatePausedState::RatePaused;
changePipelineState(GST_STATE_PAUSED);
updatePlaybackRate();
}
return;
} else if (m_playbackRatePausedState == PlaybackRatePausedState::RatePaused) {
m_playbackRatePausedState = PlaybackRatePausedState::ShouldMoveToPlaying;
Expand All @@ -652,6 +658,11 @@ void MediaPlayerPrivateGStreamer::setRate(float rate)
|| (pending == GST_STATE_PAUSED))
return;

if (m_currentState == GST_STATE_PAUSED && m_playbackRate && m_playbackRatePausedState != PlaybackRatePausedState::Playing) {
m_playbackRatePausedState = PlaybackRatePausedState::Playing;
GST_INFO_OBJECT(pipeline(), "[Buffering] Restarting playback (because of resuming from zero playback rate) in setRate");
changePipelineState(GST_STATE_PLAYING);
}
updatePlaybackRate();
}

Expand Down
7 changes: 0 additions & 7 deletions Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,6 @@ void WebFrameLoaderClient::dispatchDidReceiveResponse(DocumentLoader*, ResourceL
return;

webPage->injectedBundleResourceLoadClient().didReceiveResponseForResource(*webPage, m_frame, identifier, response);
if (response.httpStatusCode() >= 400) {
String message = "Failed to load resource: the server responded with a status of " + String::number(response.httpStatusCode()) + " (" + response.httpStatusText() + ')';
LOG(Loading,"dispatchDidReceiveResponse->message:%s", message.utf8().data());
}
}

void WebFrameLoaderClient::dispatchDidReceiveContentLength(DocumentLoader*, ResourceLoaderIdentifier identifier, int dataLength)
Expand Down Expand Up @@ -324,7 +320,6 @@ void WebFrameLoaderClient::dispatchDidFailLoading(DocumentLoader*, ResourceLoade

webPage->injectedBundleResourceLoadClient().didFailLoadForResource(*webPage, m_frame, identifier, error);
webPage->removeResourceRequest(identifier);
LOG(Loading,"dispatchedDidFailLoading: isTimeout=%d, isCancellation=%d, isAccessControl=%d, errorCode=%d description:%s", error.isTimeout(), error.isCancellation(), error.isAccessControl(), error.errorCode(), error.localizedDescription().utf8().data());
}

bool WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache(DocumentLoader*, const ResourceRequest&, const ResourceResponse&, int /*length*/)
Expand Down Expand Up @@ -638,8 +633,6 @@ void WebFrameLoaderClient::dispatchDidFailLoad(const ResourceError& error)
// If we have a load listener, notify it.
if (WebFrame::LoadListener* loadListener = m_frame->loadListener())
loadListener->didFailLoad(m_frame.ptr(), error.isCancellation());

LOG(Loading,"dispatchDidFailLoad: isTimeout= %d, isCancellation= %d, isAccessControl= %d, errorCode= %d description: %s", error.isTimeout(), error.isCancellation(), error.isAccessControl(), error.errorCode(), error.localizedDescription().utf8().data());
}

void WebFrameLoaderClient::dispatchDidFinishDocumentLoad()
Expand Down