From 4b3cbd72a249d65460fb25a8a44358bc4806a669 Mon Sep 17 00:00:00 2001 From: LiZhenCheng9527 Date: Tue, 5 Mar 2024 10:13:48 +0800 Subject: [PATCH] check for errors when deleting fleet and provides logs Signed-off-by: LiZhenCheng9527 --- pkg/fleet-manager/application/controller.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/fleet-manager/application/controller.go b/pkg/fleet-manager/application/controller.go index 185509a4..76211428 100644 --- a/pkg/fleet-manager/application/controller.go +++ b/pkg/fleet-manager/application/controller.go @@ -328,7 +328,10 @@ func (a *ApplicationManager) reconcileDelete(ctx context.Context, app *applicati fleetKey := generateFleetKey(app) fleet := &fleetapi.Fleet{} if err := a.Client.Get(ctx, fleetKey, fleet); err != nil { - log.Error(err, "failed to find fleet", "fleet", fleetKey) + if apierrors.IsNotFound(err) { + log.Info("fleet does not exist", "fleet", fleetKey) + } + log.Info("failed to get fleet", "fleet", fleetKey, "error", err) } else { if deleteErr := a.deleteResourcesInMemberClusters(ctx, app, fleet); deleteErr != nil { return ctrl.Result{}, errors.Wrapf(deleteErr, "failed to delete rollout resource in member clusters")