[REFACTOR] Reduce code duplication CAT-66

norvin-yecla-lrn · norvin-yecla-lrn · commit 937adcc3b469 · 2019-08-07T09:44:33.000+10:00
diff --git a/LearnositySDK/Request/Init.cs b/LearnositySDK/Request/Init.cs
@@ -535,18 +535,18 @@ public void addTelemetryData()
         {
             if (this.isTelemetryEnabled())
             {
+                JsonObject meta;
                 if (this.requestPacket.getJsonObject("meta") != null)
                 {
-                    JsonObject meta = this.requestPacket.getJsonObject("meta");
-                    meta.set("sdk", this.getSdkMeta());
-                    this.requestPacket.set("meta", meta);
+                    meta = this.requestPacket.getJsonObject("meta");
                 }
                 else
                 {
-                    JsonObject meta = new JsonObject();
-                    meta.set("sdk", this.getSdkMeta());
-                    this.requestPacket.set("meta", meta);
+                    meta = new JsonObject();
                 }
+
+                meta.set("sdk", this.getSdkMeta());
+                this.requestPacket.set("meta", meta);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -535,18 +535,18 @@ public void addTelemetryData()`
`535`	`535`	`{`
`536`	`536`	`if (this.isTelemetryEnabled())`
`537`	`537`	`{`
	`538`	`+ JsonObject meta;`
`538`	`539`	`if (this.requestPacket.getJsonObject("meta") != null)`
`539`	`540`	`{`
`540`		`- JsonObject meta = this.requestPacket.getJsonObject("meta");`
`541`		`- meta.set("sdk", this.getSdkMeta());`
`542`		`- this.requestPacket.set("meta", meta);`
	`541`	`+ meta = this.requestPacket.getJsonObject("meta");`
`543`	`542`	`}`
`544`	`543`	`else`
`545`	`544`	`{`
`546`		`- JsonObject meta = new JsonObject();`
`547`		`- meta.set("sdk", this.getSdkMeta());`
`548`		`- this.requestPacket.set("meta", meta);`
	`545`	`+ meta = new JsonObject();`
`549`	`546`	`}`
	`547`	`+`
	`548`	`+ meta.set("sdk", this.getSdkMeta());`
	`549`	`+ this.requestPacket.set("meta", meta);`
`550`	`550`	`}`
`551`	`551`	`}`
`552`	`552`