Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added RegisterOperatorWithChurn #514

Closed
wants to merge 50 commits into from
Closed

added RegisterOperatorWithChurn #514

wants to merge 50 commits into from

Conversation

Sidu28
Copy link
Contributor

@Sidu28 Sidu28 commented Feb 5, 2025

Fixes # .

What Changed?

Added RegisterOperatorWithChurn to avsRegistry chain writer.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@MegaRedHand
feat: prefix registration parameters with type
e3e6909
@MegaRedHand
feat: make encoding function public
a741bd2
@MegaRedHand
feat: add registration type prefix to registration
4a10928
@MegaRedHand
test: add test for abi encoding
a7b90f5
@MegaRedHand
refactor: move new type to types module
9ead4b5
@MegaRedHand
chore: lint
14b1c1c
@MegaRedHand
chore: re-add imports
bd21097
@MegaRedHand
feat: update middleware reference to v1.0.3
b15c586
@MegaRedHand
chore: format contracts
b527bf2
@MegaRedHand
chore: update SDK contracts
5564687
@MegaRedHand
feat: update bindings list
4a22a66
@MegaRedHand
chore: regenerate bindings
331ef2d
@MegaRedHand
fix: update initialize calls
d893423
@MegaRedHand
chore: regenerate anvil state dump
485bbc1
@MegaRedHand
fix: update types to use new Types interfaces
94581cc
@MegaRedHand
fix: use correct path when cleaning bindings
1ada8d8
@MegaRedHand
chore: regenerate bindings
8ad2301
@MegaRedHand
chore: re-add MockAvsServiceManager
3b7510a
@MegaRedHand
fix: update contracts
d4e3e91
@MegaRedHand
chore: regenerate bindings
f6b52e6
@MegaRedHand
fix: update types to new interface
2507e8b
@MegaRedHand
feat: set permissions on deploy script
527fb4d
@MegaRedHand
chore: regenerate state dump
f4a08d9
@MegaRedHand
fix: make serviceManager field optional
9f81a7f
@MegaRedHand
refactor: change name of new function
fb06a7f
@MegaRedHand
fix: move service manager address to Config
821f5d1
@MegaRedHand
fix: use cfg address and set in test
eeddc01
@MegaRedHand
feat: add new config to builder
94b2951
@MegaRedHand
feat: add log message when service manager address is missing
67671f4
@MegaRedHand
revert: use RegistryCoordinator instead of Slashing one
c41b4dd
MegaRedHand and others added 17 commits January 29, 2025 16:37
@MegaRedHand
test: change deployed coordinator to RegistryCoordinator
6e12b49
@MegaRedHand
chore: regenerate state dump
bacb663
@MegaRedHand
feat: add LegacyRegistryCoordinator
a6e5901
@MegaRedHand
feat: return to M2 expected state for RegistryCoordinator
7d7344f
@MegaRedHand
chore: regenerate state dump
a3ee1c6
@MegaRedHand
Merge branch 'dev' into registration-params-prefix
80179de
@MegaRedHand
fix: add service manager to config
05d0c8a
@MegaRedHand
fix: set the service manager as AVS address
f342358
@MegaRedHand
fix: remove unused variable
957067d
@MegaRedHand
fix: add service manager address to the config
10d4b8e
@MegaRedHand
chore: regenerate state dump
436390e
@MegaRedHand
chore: revert license change on contract
ad36295
@MegaRedHand
chore: remove commented code
dc8b031
@MegaRedHand
Merge branch 'dev' into registration-params-prefix
83391c4
@MegaRedHand
Merge branch 'dev' into registration-params-prefix
4bcbde7
@MegaRedHand
Merge branch 'dev' into registration-params-prefix
5feb7d1
@Sidu28
added RegisterOperatorWithChurn
daa3c5b
@Sidu28 Sidu28 requested a review from MegaRedHand February 5, 2025 20:19
MegaRedHand
MegaRedHand reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing

chainio/clients/avsregistry/writer.go Outdated Show resolved Hide resolved
@MegaRedHand MegaRedHand linked an issue Feb 6, 2025 that may be closed by this pull request
Implement RegistryCoordinator.registerOperatorWithChurn #517
Open
Base automatically changed from registration-params-prefix to dev February 6, 2025 16:12
@Sidu28 Sidu28 closed this Feb 7, 2025
@MegaRedHand MegaRedHand deleted the added-churn branch February 7, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand left review comments

@maximopalopoli maximopalopoli maximopalopoli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RegistryCoordinator.registerOperatorWithChurn
3 participants
@Sidu28 @MegaRedHand @maximopalopoli