chore: test more utils funcs

Author: estensen

types/operator.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log/slog"
 	"math/big"
+	"net/http"
 
 	"github.com/Layr-Labs/eigensdk-go/crypto/bls"
 	"github.com/Layr-Labs/eigensdk-go/utils"
@@ -46,7 +47,7 @@ func (o Operator) Validate() error {
 		return utils.WrapError(ErrInvalidMetadataUrl, err)
 	}
 
-	body, err := utils.ReadPublicURL(o.MetadataUrl)
+	body, err := utils.ReadPublicURL(o.MetadataUrl, http.DefaultClient)
 	if err != nil {
 		return utils.WrapError(ErrReadingMetadataUrlResponse, err)
 	}

types/operator_metadata.go

@@ -1,6 +1,8 @@
 package types
 
 import (
+	"net/http"
+
 	"github.com/Layr-Labs/eigensdk-go/utils"
 )
 
@@ -45,7 +47,7 @@ func (om *OperatorMetadata) Validate() error {
 		return ErrLogoRequired
 	}
 
-	if err = utils.IsImageURL(om.Logo); err != nil {
+	if err = utils.IsImageURL(om.Logo, http.DefaultClient); err != nil {
 		return err
 	}
 

utils/utils.go

@@ -105,6 +105,7 @@ func EcdsaPrivateKeyToAddress(privateKey *ecdsa.PrivateKey) (gethcommon.Address,
 	return crypto.PubkeyToAddress(*publicKeyECDSA), nil
 }
 
+// RoundUpDivideBig divides two positive big.Int numbers and rounds up the result.
 func RoundUpDivideBig(a, b *big.Int) *big.Int {
 	one := new(big.Int).SetUint64(1)
 	res := new(big.Int)
@@ -118,14 +119,13 @@ func IsValidEthereumAddress(address string) bool {
 	return ethAddrPattern.MatchString(address)
 }
 
-func ReadPublicURL(url string) ([]byte, error) {
-	// allow no redirects
-	httpClient := http.Client{
-		CheckRedirect: func(req *http.Request, via []*http.Request) error {
-			return http.ErrUseLastResponse
-		},
-		Timeout: 3 * time.Second,
+func ReadPublicURL(url string, httpClient *http.Client) ([]byte, error) {
+	// Allow no redirects
+	httpClient.CheckRedirect = func(req *http.Request, via []*http.Request) error {
+		return http.ErrUseLastResponse
 	}
+	httpClient.Timeout = 3 * time.Second
+
 	resp, err := httpClient.Get(url)
 	if err != nil {
 		return []byte{}, err
@@ -213,7 +213,7 @@ func CheckIfUrlIsValid(rawUrl string) error {
 	return nil
 }
 
-func IsImageURL(urlString string) error {
+func IsImageURL(urlString string, httpClient *http.Client) error {
 	// Parse the URL
 	parsedURL, err := url.Parse(urlString)
 	if err != nil {
@@ -229,7 +229,7 @@ func IsImageURL(urlString string) error {
 	// Check if the extension is in the list of image extensions
 	for _, imgExt := range ImageExtensions {
 		if strings.EqualFold(extension, imgExt) {
-			imageBytes, err := ReadPublicURL(urlString)
+			imageBytes, err := ReadPublicURL(urlString, httpClient)
 			if err != nil {
 				return err
 			}