Skip to content

Commit e020577

Browse files
committed
Add todo
1 parent cab245b commit e020577

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/storage/spiflash.rs

+3
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ impl SPIFlashStorage {
5353
// TODO: handle file system not formatted issue.
5454
// looks like esp-idf-svc didn't implement error handling at this moment:
5555
// https://github.com/esp-rs/esp-idf-svc/blob/6453bedd5967ebc3bcb7d240492a0d5164e818c2/src/io.rs#L130
56+
// TODO: the f_mount called with async mode, it means the actual mount will only happen in
57+
// a file operation. Maybe we should leave file sys formatting to the end-user
58+
// instead? as it's a dangerous operation anyway....
5659
self.mounted_fatfs = Some(MountedFatfs::mount(fatfs, mount_path, max_fds)?);
5760
Ok(())
5861
}

0 commit comments

Comments
 (0)