Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telnet connection does not close occasionally; results in crash when messages or commands are sent #48

Open
LakeYS opened this issue Sep 29, 2017 · 0 comments
Open

Telnet connection does not close occasionally; results in crash when messages or commands are sent #48

LakeYS opened this issue Sep 29, 2017 · 0 comments
Assignees
@LakeYS
Labels
bug

Comments

@LakeYS
Copy link
Owner

LakeYS commented Sep 29, 2017 •
edited
Loading

This can also be replicated using the Microsoft telnet client, indicating that it is not exclusive to the NodeJS telnet client.

To replicate, comment out "connection.destroy();" around line 406 and shut the server down remotely.

Have confirmed that this can occur without the server shutting down, so simply checking for a shutdown is not a suitable fix and is only considered a workaround. (See bc0d469)
@LakeYS LakeYS added the bug label Sep 29, 2017
@LakeYS LakeYS self-assigned this Sep 29, 2017
@LakeYS LakeYS changed the title Connection does not close when server shuts down, results in crash Telnet connection does not close when server shuts down, results in crash Sep 29, 2017
@LakeYS LakeYS changed the title Telnet connection does not close when server shuts down, results in crash Telnet connection does not close occasionally, particularly when server shuts down; results in crash Sep 29, 2017
@LakeYS LakeYS changed the title Telnet connection does not close occasionally, particularly when server shuts down; results in crash Telnet connection does not close occasionally; results in crash when messages or commands are sent Oct 2, 2017
This was referenced Oct 2, 2017
Closed
Closed
LakeYS referenced this issue Oct 2, 2017
@LakeYS
Implemented server shutdown detection
bc0d469 
This is a workaround for issue #13 and a partial implementation of #14.
On shutdown, an announcement is made and the telnet connection is
closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LakeYS LakeYS

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LakeYS