From 5dd47af50900d23125c12b79ac29169c290cdcf8 Mon Sep 17 00:00:00 2001 From: Insun35 Date: Tue, 3 Sep 2024 16:27:30 +0900 Subject: [PATCH] fix: include moulus as overflow --- src/gadgets/nonnative.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gadgets/nonnative.rs b/src/gadgets/nonnative.rs index be6d09e..ff14328 100644 --- a/src/gadgets/nonnative.rs +++ b/src/gadgets/nonnative.rs @@ -502,7 +502,7 @@ impl, const D: usize, FF: PrimeField> SimpleGenerat let b_biguint = b.to_canonical_biguint(); let sum_biguint = a_biguint + b_biguint; let modulus = FF::order(); - let (overflow, sum_reduced) = if sum_biguint > modulus { + let (overflow, sum_reduced) = if sum_biguint >= modulus { (true, sum_biguint - modulus) } else { (false, sum_biguint)