Skip to content

Conversation

@eduardojsbarroso
Copy link
Collaborator

For some reason, doing the interpolation for the exact recipe, in

    def evaluate_theory_prediction_lensing_profile()
    .
    .
    .
            if self.cluster_theory._beta_parameters is not None:
                self.cluster_theory.set_beta_s_interp(*z_edges)

is not giving good results. Also since we expect the cluster_theory has to be prepared with the beta parameters, I think it also should be prepared with the right beta interpolation, the same way we do for the grid recipe.

To see the error, just run the cluster_recipe.ipynb notebook in #63.
Without this fix, the figure in Cell 7, Reduced Shear — Exact vs Grid (No Interp) for 3 Radii shows that the prediction do not agree, even though both are prepared with the same cluster_theory object.

@github-actions github-actions bot changed the title Issu/64/beta exact Issu/64/beta exact [version:1.0.1] Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.36%. Comparing base (e11d9e4) to head (dbbec51).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   98.35%   98.36%   +0.01%     
==========================================
  Files          28       28              
  Lines        1758     1772      +14     
  Branches       57       58       +1     
==========================================
+ Hits         1729     1743      +14     
  Misses         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot changed the title Issu/64/beta exact [version:1.0.1] Issu/64/beta exact [version:1.0.2] Jan 21, 2026
@eduardojsbarroso eduardojsbarroso marked this pull request as draft January 21, 2026 13:49
@eduardojsbarroso eduardojsbarroso marked this pull request as ready for review January 21, 2026 13:49
@m-aguena m-aguena merged commit 24a97ce into main Jan 21, 2026
18 checks passed
@m-aguena m-aguena deleted the issu/64/beta_exact branch January 21, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants