-
Notifications
You must be signed in to change notification settings - Fork 31
Polygon clipping support in ClipField and EquiZ MIR. #1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BradWhitlock
wants to merge
30
commits into
develop
Choose a base branch
from
bugfix/whitlock/clipfield_mir_polygon_support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Polygon clipping support in ClipField and EquiZ MIR. #1735
BradWhitlock
wants to merge
30
commits into
develop
from
bugfix/whitlock/clipfield_mir_polygon_support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iterations make valid files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried
EquiZAlgorithmon a mesh with octagons and found that it could not handle polygons (just tri/quad).This PR:
TopologyMappertest that intersects 2 meshes with octagons and runs EquiZ on the resulting matset.ClipFieldandEquiZAlgorithmto handle polygons with 5-8 sides.Here we see VisIt and Axom. VisIt looks wrong for quad shapes here and successive refinement into quad/tri causes more irregular edges (also not showing all mesh edges it makes). Axom keeps zone fragments together as polygons through clipping so fewer fragments and edges are needed.

Here is another example of how clipping polygons results in fewer zone fragments:
