Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe viewer events happen in pretty much categorically the wrong order. #929

Open
chipsams opened this issue Dec 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@chipsams
Copy link

chipsams commented Dec 1, 2024

Minecraft Version

1.21

KubeJS Version

2101.7.1-build.181

Rhino Version

2101.2.5-build.54

Architectury Version

13.0.6

Forge/Fabric Version

NeoForge 21.0.167

Describe your issue

all removeEntries calls happen after all addEntries calls, which prevents, for instance, removing a very broad ingredient then re-adding a few special cases, or replacing an item with a modified version of itself, at least not without some worryingly janky alternatives. it also outright prevents the use-case of inserting things into an index in a custom order.

//expected behavior: only one gold ingot entry visible, the filter having removed the original one.
//actual behavior: none are present

RecipeViewerEvents.removeEntries("item",event=>{
  event.remove(Ingredient.of("gold_ingot"))
})

RecipeViewerEvents.addEntries("item",event=>{
  event.add(Item.of("gold_ingot"))
})

Crash report/logs

No response

@chipsams chipsams added the bug Something isn't working label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant