Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft delete unhealthy endpoints #368

Open
philbrookes opened this issue Jan 29, 2025 · 1 comment
Open

Soft delete unhealthy endpoints #368

philbrookes opened this issue Jan 29, 2025 · 1 comment
Assignees

Comments

@philbrookes
Copy link
Contributor

philbrookes commented Jan 29, 2025

Blocked by: #356 , #367

Use Case

When a health check is failing, we don't currently remove the unhealthy endpoint from the DNS provider. An unhealthy endpoint should be removed from the DNS provider as long as it wont result in a NXDoman response

When reconciling a DNS Record, label any unhealthy endpoints with "soft_delete"

Test Cases

  • New test to ensure DNS response is correct when an unhealthy cluster removed
  • New test to ensure DNS response is correct when an unhealthy cluster is identified but not removed (IE removing a whole GEO)

Document

We will want to update the health check documentation to call out this new behaviour including not removing a GEO

@philbrookes philbrookes mentioned this issue Jan 29, 2025
2 tasks
@philbrookes philbrookes moved this to Todo in Kuadrant Jan 29, 2025
@philbrookes philbrookes self-assigned this Jan 29, 2025
@philbrookes philbrookes moved this from Todo to In Progress in Kuadrant Feb 11, 2025
@maleck13 maleck13 moved this from In Progress to Todo in Kuadrant Feb 19, 2025
@philbrookes
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant