Merge pull request #87 from Konkuk-KUIT/86-last-dance

fix: Separation isRead

Author: junyongleee

src/main/java/com/archiveat/server/domain/newsletter/controller/NewsletterController.java

@@ -28,37 +28,23 @@ public ApiResponse<DeleteNewsletterResponse> deleteNewsletter(
                 return ApiResponse.ok(deleteNewsletterResponse); // 204
         }
 
-        /**
-         * AI 요약 상세 조회
-         * 
-         * @param autoMarkRead true(기본값): 컴렉션/탐색 탭에서 자동 읽음 처리, false: 홈 탭에서 버튼 클릭 시만 처리
-         */
         @GetMapping("/{userNewsletterId}")
         public ApiResponse<ViewNewsletterResponse> viewNewsletter(
                         @PathVariable Long userNewsletterId,
-                        @AuthenticationPrincipal Long userId,
-                        @RequestParam(defaultValue = "true") boolean autoMarkRead) {
+                        @AuthenticationPrincipal Long userId) {
                 ViewNewsletterResponse viewNewsletterResponse = newsletterService.viewUserNewsletter(
                                 userId,
-                                userNewsletterId,
-                                autoMarkRead);
+                                userNewsletterId);
                 return ApiResponse.ok(viewNewsletterResponse);
         }
 
-        /**
-         * Simple 상세 조회
-         * 
-         * @param autoMarkRead true(기본값): 컴렉션/탐색 탭에서 자동 읽음 처리, false: 홈 탭에서 버튼 클릭 시만 처리
-         */
         @GetMapping("/{userNewsletterId}/simple")
         public ApiResponse<SimpleViewNewsletterResponse> simpleViewNewsletter(
                         @PathVariable Long userNewsletterId,
-                        @AuthenticationPrincipal Long userId,
-                        @RequestParam(defaultValue = "true") boolean autoMarkRead) {
+                        @AuthenticationPrincipal Long userId) {
                 SimpleViewNewsletterResponse simpleViewNewsletterResponse = newsletterService.simpleViewUserNewsletter(
                                 userId,
-                                userNewsletterId,
-                                autoMarkRead);
+                                userNewsletterId);
                 return ApiResponse.ok(simpleViewNewsletterResponse);
         }
 

src/main/java/com/archiveat/server/domain/newsletter/service/NewsletterService.java

@@ -90,21 +90,11 @@ public DeleteNewsletterResponse deleteUserNewsletter(Long userId, Long userNewsl
      * 뉴스레터 AI 요약 상세 조회
      */
     @Transactional
-    public ViewNewsletterResponse viewUserNewsletter(Long userId, Long userNewsletterId, boolean autoMarkRead) {
+    public ViewNewsletterResponse viewUserNewsletter(Long userId, Long userNewsletterId) {
         UserNewsletter userNewsletter = userNewsletterRepository
                 .findByIdAndUser_Id(userNewsletterId, userId)
                 .orElseThrow(() -> new CustomException(ErrorCode.USER_NEWSLETTER_NOT_FOUND));
 
-        if (autoMarkRead) {
-            if (!userNewsletter.isRead())
-                userNewsletter.updateIsRead();
-            else
-                userNewsletter.updateLastViewedAt();
-        } else {
-            userNewsletter.updateLastViewedAt();
-        }
-        userNewsletterRepository.save(userNewsletter);
-
         Newsletter newsletter = userNewsletter.getNewsletter();
         List<NewsletterSummaryBlock> summaryBlocks = parseNewsletterSummary(newsletter.getNewsletterSummary());
 
@@ -155,20 +145,12 @@ private List<NewsletterSummaryBlock> parseNewsletterSummary(String newsletterSum
      * 뉴스레터 Simple 상세 조회
      */
     @Transactional
-    public SimpleViewNewsletterResponse simpleViewUserNewsletter(Long userId, Long userNewsletterId,
-            boolean autoMarkRead) {
+    public SimpleViewNewsletterResponse simpleViewUserNewsletter(Long userId, Long userNewsletterId) {
         UserNewsletter userNewsletter = userNewsletterRepository
                 .findByIdAndUser_Id(userNewsletterId, userId)
                 .orElseThrow(() -> new CustomException(ErrorCode.USER_NEWSLETTER_NOT_FOUND));
 
-        if (autoMarkRead) {
-            if (!userNewsletter.isRead())
-                userNewsletter.updateIsRead();
-            else
-                userNewsletter.updateLastViewedAt();
-        } else {
-            userNewsletter.updateLastViewedAt();
-        }
+        userNewsletter.updateIsRead();
         userNewsletterRepository.save(userNewsletter);
 
         Newsletter newsletter = userNewsletter.getNewsletter();

src/test/java/com/archiveat/server/domain/newsletter/service/NewsletterServiceTest.java

@@ -63,8 +63,7 @@ void simpleViewUserNewsletter_ReturnsFirstSummaryBlock() throws Exception {
 
                 // when
                 SimpleViewNewsletterResponse response = newsletterService.simpleViewUserNewsletter(userId,
-                                userNewsletterId,
-                                true);
+                                userNewsletterId);
 
                 // then
                 assertThat(response.newsletterSimpleSummary()).hasSize(1);
@@ -100,8 +99,7 @@ void simpleViewUserNewsletter_ReturnsEmptyList_WhenSummaryIsEmpty() throws Excep
 
                 // when
                 SimpleViewNewsletterResponse response = newsletterService.simpleViewUserNewsletter(userId,
-                                userNewsletterId,
-                                true);
+                                userNewsletterId);
 
                 // then
                 assertThat(response.newsletterSimpleSummary()).isEmpty();
@@ -135,7 +133,7 @@ void viewUserNewsletter_ShouldReturnPersonalizedClassification() {
                 given(userTopic.getName()).willReturn("PersonalizedTopic");
 
                 // when
-                ViewNewsletterResponse response = newsletterService.viewUserNewsletter(userId, userNewsletterId, false);
+                ViewNewsletterResponse response = newsletterService.viewUserNewsletter(userId, userNewsletterId);
 
                 // then
                 assertThat(response.categoryName()).isEqualTo("PersonalizedCategory");
@@ -168,7 +166,7 @@ void viewUserNewsletter_ShouldFallbackToOriginalClassification() {
                 given(newsletter.getTopic()).willReturn("OriginalTopic");
 
                 // when
-                ViewNewsletterResponse response = newsletterService.viewUserNewsletter(userId, userNewsletterId, false);
+                ViewNewsletterResponse response = newsletterService.viewUserNewsletter(userId, userNewsletterId);
 
                 // then
                 assertThat(response.categoryName()).isEqualTo("OriginalCategory");