Skip to content

Add mirror fields to KonnectGatewayControlPlane #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
mlavacca opened this issue Apr 8, 2025 · 0 comments · Fixed by #387
Closed
1 task

Add mirror fields to KonnectGatewayControlPlane #383

mlavacca opened this issue Apr 8, 2025 · 0 comments · Fixed by #387

Comments

@mlavacca
Copy link
Member

mlavacca commented Apr 8, 2025

Problem Statement

In the context of KonnectID references, the KonnectGatewayControlPlane has to be improved to belong to different types: origin and mirror.

Proposed Solution

Add a new type field to the KonnectGatewayControlPlane spec. This field is an enum that can have two possible values:

  • origin (default enforced by cel)
  • mirror

Together with the type field, a new MirrorSpec field has to be added: this field is a struct that contains (for the time being) only a string for the konnectID.

Cel validation is added to ensure that:

  • in case type is origin, MirrorSpec is empty
  • in case type is mirror, MirrorSpec is not empty and the origin-related fields (the ControlPlane spec) are empty

Acceptance Criteria

  • As a user, I can set a KonnectGatewayControlPlane to be either of origin type or mirror type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant