chore: add comment about not supporting cross namespace references between KongRoute and KongService

pmalek · pmalek · commit 0dd95837a5ef · 2024-10-03T10:09:03.000+02:00
diff --git a/controller/konnect/index_kongroute.go b/controller/konnect/index_kongroute.go
@@ -51,10 +51,8 @@ func kongRouteRefersToKongService(object client.Object) []string {
 		return nil
 	}
 
-	namespace := route.Namespace
-	if svcRef.NamespacedRef.Namespace != "" {
-		namespace = svcRef.NamespacedRef.Namespace
-	}
+	// NOTE: We currently do not allow cross namespace references between KongRoute and KongService.
+	// https://github.com/Kong/kubernetes-configuration/issues/106 tracks the implementation.
 
-	return []string{namespace + "/" + svcRef.NamespacedRef.Name}
+	return []string{route.Namespace + "/" + svcRef.NamespacedRef.Name}
 }

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,8 @@ func kongRouteRefersToKongService(object client.Object) []string {`
`51`	`51`	`return nil`
`52`	`52`	`}`
`53`	`53`
`54`		`- namespace := route.Namespace`
`55`		`- if svcRef.NamespacedRef.Namespace != "" {`
`56`		`- namespace = svcRef.NamespacedRef.Namespace`
`57`		`- }`
	`54`	`+ // NOTE: We currently do not allow cross namespace references between KongRoute and KongService.`
	`55`	`+ // https://github.com/Kong/kubernetes-configuration/issues/106 tracks the implementation.`
`58`	`56`
`59`		`- return []string{namespace + "/" + svcRef.NamespacedRef.Name}`
	`57`	`+ return []string{route.Namespace + "/" + svcRef.NamespacedRef.Name}`
`60`	`58`	`}`