Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Commit 532373a

Browse files
authored
Merge pull request #352 from KnisterPeter/named-imports
refactor: use named imports in favor of import all
2 parents b525016 + cc1fa8b commit 532373a

10 files changed

+19
-19
lines changed

src/typings.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export function createTypings(moduleName: string|null, programAst: any, options:
3333

3434
const m = dom.create.module(moduleName || 'moduleName');
3535
if (hasReactClass(ast, reactComponentName)) {
36-
m.members.push(dom.create.importAll('React', 'react'));
36+
m.members.push(dom.create.importNamed('Component', 'react'));
3737
}
3838
if (importStatements.length > 0) {
3939
importStatements.forEach(importStatement => {
@@ -80,7 +80,7 @@ function createExportedTypes(m: dom.ModuleDeclaration, ast: AstQuery, componentN
8080

8181
if (classComponent) {
8282
const classDecl = dom.create.class(componentName);
83-
classDecl.baseType = dom.create.interface(`React.Component<${interf.name}, any>`);
83+
classDecl.baseType = dom.create.interface(`Component<${interf.name}, any>`);
8484
classDecl.flags = exportType;
8585
classDecl.members.push(dom.create.method('render', [], dom.create.namedTypeReference('JSX.Element')));
8686
m.members.push(classDecl);

tests/component-without-proptyes.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
declare module 'component' {
2-
import * as React from 'react';
2+
import {Component} from 'react';
33

44
export interface TestProps {
55
}
66

7-
export default class Test extends React.Component<TestProps, any> {
7+
export default class Test extends Component<TestProps, any> {
88
render(): JSX.Element;
99
}
1010

tests/es6-class.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
declare module 'component' {
2-
import * as React from 'react';
2+
import {Component} from 'react';
33

44
import Message from './path/to/Message';
55

@@ -52,7 +52,7 @@ declare module 'component' {
5252
requiredSymbol: typeof Symbol;
5353
}
5454

55-
export class Component extends React.Component<ComponentProps, any> {
55+
export class Component extends Component<ComponentProps, any> {
5656
render(): JSX.Element;
5757
}
5858
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
declare module 'component' {
2-
import * as React from 'react';
2+
import {Component} from 'react';
33

44
export interface ComponentProps {
55
optionalAny?: any;
66
}
77

8-
export default class Component extends React.Component<ComponentProps, any> {
8+
export default class Component extends Component<ComponentProps, any> {
99
render(): JSX.Element;
1010
}
1111
}

tests/es7-class-top-level-module.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as React from 'react';
1+
import {Component} from 'react';
22
import Message from './path/to/Message';
33

44
export type ComponentOptionalUnion = string | number;
@@ -27,6 +27,6 @@ export interface ComponentProps {
2727
requiredArrayOf: string[];
2828
}
2929

30-
export default class Component extends React.Component<ComponentProps, any> {
30+
export default class Component extends Component<ComponentProps, any> {
3131
render(): JSX.Element;
3232
}

tests/es7-class.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
declare module 'component' {
2-
import * as React from 'react';
2+
import {Component} from 'react';
33
import Message from './path/to/Message';
44

55
export type ComponentOptionalUnion = string | number;
@@ -28,7 +28,7 @@ declare module 'component' {
2828
requiredArrayOf: string[];
2929
}
3030

31-
export default class Component extends React.Component<ComponentProps, any> {
31+
export default class Component extends Component<ComponentProps, any> {
3232
render(): JSX.Element;
3333
}
3434
}

tests/import-react-component.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
declare module 'component' {
2-
import * as React from 'react';
2+
import {Component} from 'react';
33
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
declare module 'component' {
2-
import * as React from 'react';
2+
import {Component} from 'react';
33
import Member from './member';
44

55
export interface TestProps {
66
test?: typeof Member;
77
}
88

9-
export class Test extends React.Component<TestProps, any> {
9+
export class Test extends Component<TestProps, any> {
1010
render(): JSX.Element;
1111
}
1212
}

tests/references-in-proptypes.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
declare module 'component' {
2-
import * as React from 'react';
2+
import {Component} from 'react';
33

44
export type SomeComponentSomeOneOf = 'foo' | 'bar';
55

@@ -12,7 +12,7 @@ declare module 'component' {
1212
someShape?: SomeComponentSomeShape;
1313
}
1414

15-
export default class SomeComponent extends React.Component<SomeComponentProps, any> {
15+
export default class SomeComponent extends Component<SomeComponentProps, any> {
1616
render(): JSX.Element;
1717
}
1818
}

tests/unnamed-default-export.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
declare module 'path' {
2-
import * as React from 'react';
2+
import {Component} from 'react';
33

44
export interface Props {
55
onClick?: (...args: any[]) => any;
66
}
77

8-
export default class extends React.Component<Props, any> {
8+
export default class extends Component<Props, any> {
99
render(): JSX.Element;
1010
}
1111
}

0 commit comments

Comments
 (0)