feat(Core): Various additions to core functionalities

CellArray
- Implemented insertNextCell
- Implemented initialize
- getNumberOfCells and getCellSizes now use publicAPI.getData() instead of model.values

DataArray
- Implemented getValue and setValue
- Implemented insertTuple
- Implemented insertNextTuple
- Implemented deepCopy
- Implemented interpolateTuple
- getRange now uses publicAPI.getData() instead of model.values
- getNumberOfValues and getNumberOfTuples now use model.size instead of model.values.length
- model.size defaults to model.values.length if not specified during initialization

Points
- Implemented insertNextPoint
- Added tests

FieldData
- Implemented interpolateData
- Changes to passData and a bugfix
- addArray now checks if an array with the given name already exists and replaces it in that case.

DataSetAttributes
- Implemented getAttributes
- Implemented copyScalarsOn
- Implemented copyVectorsOn
- Implemented copyNormalsOn
- Implemented copyTCoordsOn
- Implemented copyTensorsOn
- Implemented copyGlobalIdsOn
- Implemented copyPedigreeIdsOn

Co-authored-by: Julien Finet <[email protected]>

Author: 2 people

Sources/Common/Core/CellArray/index.d.ts

@@ -1,52 +1,49 @@
-import { TypedArray } from "../../../types";
-import vtkDataArray, { IDataArrayInitialValues } from "../../Core/DataArray";
-
+import { TypedArray } from '../../../types';
+import vtkDataArray, { IDataArrayInitialValues } from '../../Core/DataArray';
 
 /**
  * The inital values of a vtkCellArray.
  */
 export interface ICellArrayInitialValues extends IDataArrayInitialValues {
-	empty?: boolean;
+  empty?: boolean;
 }
 
 export interface vtkCellArray extends vtkDataArray {
+  /**
+   * Get the number of cells in the array.
+   * @param {Boolean} [recompute] Recompute the number of cells.
+   */
+  getNumberOfCells(recompute?: boolean): number;
 
-	/**
-	 * Get the number of cells in the array.
-	 * @param {Boolean} [recompute] Recompute the number of cells.
-	 */
-	getNumberOfCells(recompute?: boolean): number;
-
-	/**
-	 * Get the sizes of the cells in this array.
-	 * @param {Boolean} [recompute] Recompute the cell sizes.
-	 */
-	getCellSizes(recompute?: boolean): any;
+  /**
+   * Get the sizes of the cells in this array. Get the sizes of the cells in this array.
+   * @param {Boolean} [recompute] Recompute the cell sizes.
+   */
+  getCellSizes(recompute?: boolean): any;
 
-	/**
-	 * Set the data of this array.
-	 * @param {TypedArray} typedArray The Array value.
-	 */
-	setData(typedArray: TypedArray): void;
+  /**
+   * Set the data of this array.
+   * @param {TypedArray} typedArray The typedArray value.
+   */
+  setData(typedArray: TypedArray): void;
 
-	/**
-	 * Returns the point indices at the given location as a subarray.
-	 * @param loc
-	 */
-	getCell(loc: any): void;
+  /**
+   * Returns the point indices at the given location as a subarray.
+   * @param loc
+   */
+  getCell(loc: any): void;
 
-	/**
-	 * Reset the cell array by setting the number of cells to 0.
-	 * NOTE: This won't touch the actual memory of the underlying typedArray.
-	 */
-	initialize(): void;
+  /**
+   * Reset this array.
+   * NOTE: This won't touch the actual memory of the underlying typedArray.
+   */
+  initialize(): void;
 
-	/**
-	 * Insert a cell to this array in the next available slot.
-	 * @param {Number[]} cellPointIds The list of point ids (NOT prefixed with the number of points)
-	 * @returns {Number} Idx of where the cell was inserted
-	 */
-	insertNextCell(cellPointIds: number[]): number;
+  /**
+   * Insert a cell to this array in the next available slot.
+   * @param {Number[]} cellPoinIds
+   */
+  insertNextCell(cellPoinIds: Number[]): void;
 }
 
 /**
@@ -56,37 +53,42 @@ export interface vtkCellArray extends vtkDataArray {
  * @param model object on which data structure will be bounds (protected)
  * @param {ICellArrayInitialValues} [initialValues] (default: {})
  */
-export function extend(publicAPI: object, model: object, initialValues?: ICellArrayInitialValues): void;
+export function extend(
+  publicAPI: object,
+  model: object,
+  initialValues?: ICellArrayInitialValues
+): void;
 
 /**
  * Method used to create a new instance of vtkCellArray
  * @param {ICellArrayInitialValues} [initialValues] for pre-setting some of its content
  */
-export function newInstance(initialValues?: ICellArrayInitialValues): vtkCellArray;
-
+export function newInstance(
+  initialValues?: ICellArrayInitialValues
+): vtkCellArray;
 
 /**
  * @static
  * @param cellArray
  */
 export function extractCellSizes(cellArray: any): any;
 
- /**
-  * @static
-  * @param cellArray
-  */
+/**
+ * @static
+ * @param cellArray
+ */
 export function getNumberOfCells(cellArray: any): any;
 
 /**
  * vtkCellArray stores dataset topologies as an explicit connectivity table
  * listing the point ids that make up each cell.
- * 
+ *
  * @see [vtkDataArray](./Common_Core_DataArray.html)
  */
 export declare const vtkCellArray: {
-    newInstance: typeof newInstance;
-    extend: typeof extend;
-	extractCellSizes: typeof extractCellSizes;
-	getNumberOfCells: typeof getNumberOfCells;
-}
+  newInstance: typeof newInstance;
+  extend: typeof extend;
+  extractCellSizes: typeof extractCellSizes;
+  getNumberOfCells: typeof getNumberOfCells;
+};
 export default vtkCellArray;

Sources/Common/Core/CellArray/index.js

@@ -81,15 +81,17 @@ function vtkCellArray(publicAPI, model) {
   const superInitialize = publicAPI.initialize;
   publicAPI.initialize = () => {
     superInitialize();
-    // Set to undefined to ensure insertNextCell works correctly
     model.numberOfCells = undefined;
     model.cellSizes = undefined;
   };
 
   publicAPI.insertNextCell = (cellPointIds) => {
     const cellId = publicAPI.getNumberOfCells();
-    publicAPI.insertNextTuples([cellPointIds.length, ...cellPointIds]);
-    // By computing the number of cells earlier, we made sure that numberOfCells is defined
+    const numberOfPoints = cellPointIds.length;
+    publicAPI.insertNextTuple([numberOfPoints]);
+    for (let i = 0; i < numberOfPoints; ++i) {
+      publicAPI.insertNextTuple([cellPointIds[i]]);
+    }
     ++model.numberOfCells;
     if (model.cellSizes != null) {
       model.cellSizes.push(cellPointIds.length);