Prohibit Usage of Character _ in Unique Network Identifiers

[kmlbgn]

Description

In the context of the network, many identifiers are unique and used extensively. For the purpose of maintaining the security of these unique identifiers, especially in relation to the utilization of prefixes, it is recommended that the usage of the character _ be prohibited for all users.

• Identity Registrar :
  

  sekai/x/gov/keeper/identity_registrar.go

  Lines 18 to 21 in 1b8573d

  	func ValidateIdentityRecordKey(key string) bool {
  	regex := regexp.MustCompile(`^[a-zA-Z][_0-9a-zA-Z]*$`)
  	return regex.MatchString(key)
  	}

• SID roles:
  

  sekai/x/gov/keeper/util.go

  Lines 92 to 95 in 1b8573d

  	func ValidateRoleSidKey(key string) bool {
  	regex := regexp.MustCompile(`^[a-zA-Z][_0-9a-zA-Z]*$`)
  	return regex.MatchString(key)
  	}

• Spending Pool :
  

  sekai/x/spending/types/keys.go

  Lines 30 to 33 in 1b8573d

  	func ValidateSpendingPoolName(name string) bool {
  	regex := regexp.MustCompile(`^[a-zA-Z][_0-9a-zA-Z]*$`)
  	return regex.MatchString(name)
  	}

• Missing ValidateDappName for dApp names

• Unique identifiers should not be purely numerical. While they can include numbers, they must contain at least one non-numerical character.

• Missing ValidateTokenDenom for token denom when adding token rate & token alias (Token module) and minting module (Layer 2 module). But this issue should be in consideration of potential merging of minting module with token module Migrate Minting module from Layer 2 module to Token Module and Refactor Token Module Structure #664

[kmlbgn]

@jgo121
After reviewing the ABR specification, it should be added here that unique identifiers should not be purely numerical. While they can include numbers, they must contain at least one non-numerical character.