List of issues related to Polls module logic

[kmlbgn]

• (k msgServer) PollVote function is missing error handling logic for properties.MaxProposalPollOptionSize and utf8string.NewString(v).IsASCII() when user provide non-existing custom values.
  

  sekai/x/gov/keeper/msg_server.go

  Lines 263 to 266 in 7027803

  	if msg.Option == types.PollOptionCustom && poll.Options.Count > uint64(len(poll.Options.Values)) && !inSlice(poll.Options.Values, msg.Value) {
  	poll.Options.Values = append(poll.Options.Values, msg.Value)
  	k.keeper.SavePoll(ctx, poll)
  	}

• Wrong error type here
  

  sekai/x/gov/keeper/msg_server.go

  Lines 165 to 167 in 7027803

  	if len(msg.Checksum) > int(properties.MaxProposalChecksumSize) {
  	return nil, types.ErrProposalTitleSizeExceeds
  	}

• Duration logic between proposal and poll should be normalized. We prioritise simple logic and let abstraction work to front-end. Hence current Poll duration logic, where user can provide any duration in a form of string, should be switched for precise end-date as unix timestamp like for Proposals.
  

  sekai/x/gov/keeper/msg_server.go

  Lines 173 to 176 in 7027803

  	duration, err := time.ParseDuration(msg.Duration)
  	if err != nil || blockTime.Add(duration).Before(blockTime) {
  	return nil, fmt.Errorf("invalid duration: %w", err)
  	}

  
  with a simple check like below :
  

  sekai/x/gov/keeper/msg_server.go

  Lines 104 to 106 in 7027803

  	if proposal.VotingEndTime.Before(ctx.BlockTime()) {
  	return nil, types.ErrVotingTimeEnded
  	}

• There is no min-max bounds on poll duration value, there should be. Polls can use existing minimum_proposal_end_time network property. Additionally a new network property maximum_proposal_end_time should be created and enforced both for polls and proposals because KIRA will potentially be trimming historical state in the future which could break some L2 app logic.

• 128 as default value for network property on option count limit seem way too high
  

  sekai/x/gov/types/genesis.go

  Line 146 in 7027803

  MaxProposalPollOptionCount: 128,