Repository navigation
Commit bd4668e
authored
fix(mobile): open the reviewed pull request without a GitHub connection (#9305)
* fix(mobile): open the reviewed pull request without a GitHub connection
A personal Code Reviewer review can exist for a user who never authorized
the GitHub app, and the review detail sent every github.com pull request to
the in-app reader. That route is gated on the user's own GitHub
authorization, so the button ended on the Connect empty state instead of
the pull request.
Open the pull request in the app only when the authorization read reports
connected; otherwise (not connected, still loading, or failed) open the
review's pr_url in the browser, as organization reviews already do. The
connect gate itself is unchanged, so the comment, review and merge actions
still require the authorization.
* fix(mobile): tidy the code review detail screen
The review detail painted its status twice: the conclusion line above the
findings and a Status row in the Gate card. The Gate card now carries the
check run and the threshold only.
The pull request is the screen's primary action, so it takes the filled
primary button style; the session transcript entry stays secondary.
The byline under the pull request title repeated the repository the header
eyebrow already names. It now reads the number and the author, and every
catalog drops the repository placeholder with it.
* fix(mobile): decide the review pull-request reader from its URL
The connection read that the Open pull request button consults was enabled
from the review row's platform column, while the button's in-app decision
already followed the provider parsed from the pull-request URL. A row whose
column disagreed with its URL therefore read the authorization for the wrong
provider: a connected user whose row said another platform still went to the
browser.
Both now use the one URL-derived destination, computed once on the screen, so
the button and its read can never disagree. A mounted test covers the
mismatched row.
* fix(mobile): restyle the review detail's empty result and actions
The empty Findings section now sits in the same rounded card as the Gate
and Details bodies, so an ended review with nothing to report reads as a
filled section instead of a caption.
Session transcript moves from the top of the content into the action
group, after the primary Open pull request button, so the review title
leads the screen. The mounted suite asserts both placements.
* test(mobile): require each reference label before comparing placements
The transcript placement test compared indexes that are -1 for absent copy,
and every ordering assertion holds against -1. Assert the title, Details and
Open pull request labels are present first.1 parent 274f33d commit bd4668e
92 files changed
Lines changed: 296 additions & 124 deletions
File tree
- apps/mobile/src
- components/code-reviewer
- i18n/locales
- lib
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
76 | 80 | | |
77 | 81 | | |
78 | 82 | | |
| |||
175 | 179 | | |
176 | 180 | | |
177 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
178 | 187 | | |
179 | 188 | | |
180 | 189 | | |
| |||
188 | 197 | | |
189 | 198 | | |
190 | 199 | | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
191 | 204 | | |
192 | 205 | | |
193 | 206 | | |
| |||
313 | 326 | | |
314 | 327 | | |
315 | 328 | | |
| 329 | + | |
| 330 | + | |
316 | 331 | | |
317 | 332 | | |
318 | 333 | | |
| |||
379 | 394 | | |
380 | 395 | | |
381 | 396 | | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
382 | 416 | | |
383 | 417 | | |
384 | 418 | | |
| |||
524 | 558 | | |
525 | 559 | | |
526 | 560 | | |
527 | | - | |
528 | | - | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
529 | 564 | | |
530 | 565 | | |
531 | 566 | | |
| |||
759 | 794 | | |
760 | 795 | | |
761 | 796 | | |
762 | | - | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
763 | 848 | | |
764 | 849 | | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
765 | 885 | | |
766 | 886 | | |
767 | 887 | | |
| |||
940 | 1060 | | |
941 | 1061 | | |
942 | 1062 | | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
943 | 1083 | | |
944 | 1084 | | |
945 | 1085 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
98 | 100 | | |
99 | 101 | | |
100 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
101 | 122 | | |
102 | 123 | | |
103 | 124 | | |
| |||
235 | 256 | | |
236 | 257 | | |
237 | 258 | | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | 259 | | |
252 | 260 | | |
253 | 261 | | |
| |||
259 | 267 | | |
260 | 268 | | |
261 | 269 | | |
262 | | - | |
263 | 270 | | |
264 | 271 | | |
265 | 272 | | |
| |||
291 | 298 | | |
292 | 299 | | |
293 | 300 | | |
294 | | - | |
295 | | - | |
296 | | - | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
297 | 308 | | |
298 | 309 | | |
299 | 310 | | |
| |||
316 | 327 | | |
317 | 328 | | |
318 | 329 | | |
319 | | - | |
| 330 | + | |
| 331 | + | |
320 | 332 | | |
321 | 333 | | |
322 | 334 | | |
323 | | - | |
324 | 335 | | |
325 | 336 | | |
326 | 337 | | |
| |||
369 | 380 | | |
370 | 381 | | |
371 | 382 | | |
372 | | - | |
| 383 | + | |
| 384 | + | |
373 | 385 | | |
374 | 386 | | |
375 | | - | |
376 | 387 | | |
377 | | - | |
378 | | - | |
379 | | - | |
380 | | - | |
381 | | - | |
382 | | - | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
383 | 400 | | |
384 | 401 | | |
385 | 402 | | |
| |||
391 | 408 | | |
392 | 409 | | |
393 | 410 | | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
394 | 423 | | |
395 | 424 | | |
396 | 425 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
94 | 93 | | |
95 | 94 | | |
96 | 95 | | |
97 | 96 | | |
98 | | - | |
99 | 97 | | |
100 | 98 | | |
101 | 99 | | |
| |||
110 | 108 | | |
111 | 109 | | |
112 | 110 | | |
113 | | - | |
114 | 111 | | |
115 | 112 | | |
116 | 113 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments