Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dark Mode #58

Open
LumiWasTaken opened this issue Dec 5, 2024 · 5 comments
Open

Feature Request: Dark Mode #58

LumiWasTaken opened this issue Dec 5, 2024 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@LumiWasTaken
Copy link

Yo,

it's me with another UX Request:
Dark Mode.

it seems like my Extension for darkmode is a bit upset given that i open it locally via http://localhost:8757 (127.0.0.1 doesnt work btw)

Thank you!

@LumiWasTaken
Copy link
Author

LumiWasTaken commented Dec 5, 2024

Found an issue from my Extension in the console:
TypeError: bgColor is null

@scosman scosman added the enhancement New feature or request label Dec 5, 2024
@scosman scosman added this to the v2 milestone Dec 5, 2024
@scosman
Copy link
Collaborator

scosman commented Dec 5, 2024

Might do this later, but it's pretty far down the list. Can't promise compatibility with any extensions. DaisyUI themes actually make this pretty easy, but would need to audit every screen for hardcoded colours.

@LumiWasTaken
Copy link
Author

No worries, but i highlighted the Console error, maybe setting the Bg colour to a white value directly would help in some cases with the extension as a intermediairy.

Slowly i'm getting the feeling i need to start looking into how to compile it locally heh... do you have a vague guideline for it so i could look into it myself?

@scosman
Copy link
Collaborator

scosman commented Dec 5, 2024

Setup instructions are here: https://github.com/Kiln-AI/Kiln/blob/main/CONTRIBUTING.md

But I think that error is from your extension, not Kiln?

@LumiWasTaken
Copy link
Author

Setup instructions are here: https://github.com/Kiln-AI/Kiln/blob/main/CONTRIBUTING.md

But I think that error is from your extension, not Kiln?

Thank you.

The extension is pretty popular "Dark Reader" and the error kind of hints that yes maybe i should report that to the authors of the Extension given that it's a bug BUT since its modifying the website and Bg colour is null it seems that on both sides something might've gotten buggy.

Nobody did something wrong, maybe just an incompatibility. But i am curious to find out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants