Skip to content

Commit 24615a5

Browse files
authored
Merge pull request #327 from Kernel360/fix/car-api-fix
feat: car 생성시 고정 bizid 제거
2 parents 35f970d + b1a3a10 commit 24615a5

7 files changed

Lines changed: 15 additions & 18 deletions

File tree

tracky-core/src/main/java/kernel360/trackycore/core/domain/provider/BizProvider.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@ public class BizProvider {
1414

1515
private final BizRepository bizRepository;
1616

17-
public BizEntity getBiz(Long id) {
18-
return bizRepository.findById(id)
19-
.orElseThrow(() -> GlobalException.throwError(ErrorCode.BIZ_NOT_FOUND));
20-
}
21-
2217
public BizEntity getBiz(String bizUuid) {
2318
return bizRepository.findByBizUuid(bizUuid)
2419
.orElseThrow(() -> GlobalException.throwError(ErrorCode.BIZ_NOT_FOUND));

tracky-web/src/main/java/kernel360/trackyweb/car/application/CarService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,11 @@ public ApiResponse<CarDetailResponse> searchOne(String mdn) {
9292
* @return 등록 성공한 차량 detail
9393
*/
9494
@Transactional
95-
public ApiResponse<CarDetailResponse> create(CarCreateRequest carCreateRequest) {
95+
public ApiResponse<CarDetailResponse> create(String bizUuid, CarCreateRequest carCreateRequest) {
9696
DeviceEntity device = deviceProvider.getDevice(1L);
9797

9898
// device 세팅 넣은 car 객체 <- 임시로 모든 차량은 device 세팅 1번
99-
BizEntity biz = bizProvider.getBiz(1L);
99+
BizEntity biz = bizProvider.getBiz(bizUuid);
100100

101101
carProvider.existsByMdnOps(carCreateRequest.mdn());
102102

tracky-web/src/main/java/kernel360/trackyweb/car/domain/provider/CarDomainProvider.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,22 +36,14 @@ public Page<CarEntity> searchCarByFilter(
3636
}
3737

3838
public CarEntity update(CarEntity car) {
39-
40-
globalSseEvent.sendEvent(SseEvent.CAR_UPDATED);
41-
4239
return carDomainRepository.save(car);
4340
}
4441

4542
public CarEntity save(CarEntity car) {
46-
47-
globalSseEvent.sendEvent(SseEvent.CAR_CREATED);
48-
4943
return carDomainRepository.save(car);
5044
}
5145

5246
public void delete(String mdn) {
53-
globalSseEvent.sendEvent(SseEvent.CAR_DELETED);
54-
5547
carDomainRepository.deleteByMdn(mdn);
5648
}
5749

tracky-web/src/main/java/kernel360/trackyweb/car/infrastructure/repository/CarDomainRepositoryCustomImpl.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ public List<String> findAllMdnByBizId(String bizUuid) {
5151
@Override
5252
public Page<CarEntity> searchCarByFilter(String bizUuid, String search, CarStatus status, CarType carType,
5353
Pageable pageable) {
54+
55+
56+
5457
BooleanBuilder builder = new BooleanBuilder()
5558
.and(carEntity.biz.bizUuid.eq(bizUuid))
5659
.and(isContainsCarMdnOrCarPlate(search))

tracky-web/src/main/java/kernel360/trackyweb/car/presentation/CarApiDocs.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ ApiResponse<List<CarResponse>> getAllBySearchFilter(
3535
ApiResponse<CarDetailResponse> searchOne(@PathVariable String mdn);
3636

3737
@Operation(summary = "차량 신규 등록", description = "차량 신규 등록 API")
38-
ApiResponse<CarDetailResponse> create(@RequestBody CarCreateRequest carCreateRequest);
38+
ApiResponse<CarDetailResponse> create(@RequestBody CarCreateRequest carCreateRequest, @Schema(hidden = true) @AuthenticationPrincipal MemberPrincipal memberPrincipal);
3939

4040
@Operation(summary = "차량 정보 수정", description = "차량 정보를 수정하는 API")
4141
ApiResponse<CarDetailResponse> update(@RequestBody CarUpdateRequest carUpdateRequest);

tracky-web/src/main/java/kernel360/trackyweb/car/presentation/CarController.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,10 @@ public ApiResponse<CarDetailResponse> searchOne(
6363

6464
@PostMapping("")
6565
public ApiResponse<CarDetailResponse> create(
66-
@RequestBody CarCreateRequest carCreateRequest
66+
@RequestBody CarCreateRequest carCreateRequest,
67+
@Schema(hidden = true) @AuthenticationPrincipal MemberPrincipal memberPrincipal
6768
) {
68-
return carService.create(carCreateRequest);
69+
return carService.create(memberPrincipal.bizUuid(), carCreateRequest);
6970
}
7071

7172
@PatchMapping("")

tracky-web/src/main/java/kernel360/trackyweb/dashboard/presentation/DashBoardController.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,10 @@ public ApiResponse<Statistics> getStatistics(
4848
public ApiResponse<String> updateStatusToReturn(@PathVariable String rentUuid) {
4949
return dashBoardService.updateStatusToReturn(rentUuid);
5050
}
51+
52+
@GetMapping("/geo")
53+
public ApiResponse<Map<String, Integer>> getGeoData() {
54+
Map<String, Integer> geoMap = dashBoardService.getGeoData();
55+
return ApiResponse.success(geoMap);
56+
}
5157
}

0 commit comments

Comments
 (0)