Skip to content

Conversation

@jhtschultz
Copy link
Contributor

OpenSpiel wrapper improvements:

  • Moves OpenSpiel game and state objects from global variables to env
    instance variables.
  • Stores complete state and action history in env.info.
  • Cleaner logic for registering envs.
  • Open Spiel proxies are loaded by default if they exist and are
    accessed without the {game_name}_proxy suffix.
  • Adds logging.
  • Removes remaining references to GameMaster agent, particularly in
    default HTML renderer.

Adds chess, Go, poker, and tic-tac-toe UIs.

- Moves Open Spiel game and state objects from global variables to env
instance variables.
- Stores complete state and action history in env.info.
- Cleaner logic for registering envs.
- Open Spiel proxies are loaded by default if they exist and are
  accessed without the {game_name}_proxy suffix.
- Adds logging.
- Removes remaining references to GameMaster agent, particularly in
  default HTML renderer.
@jhtschultz jhtschultz requested a review from bovard June 16, 2025 13:37
@bovard
Copy link
Member

bovard commented Jun 16, 2025

Tests are failing

__________________________________________ test_envs_load __________________________________________

    def test_envs_load():
>       envs = open_spiel_env._register_open_spiel_envs()
E       AttributeError: module 'open_spiel.open_spiel' has no attribute '_register_open_spiel_envs'

kaggle_environments/envs/open_spiel/test_open_spiel.py:7: AttributeError
___________________________________ test_tic_tac_toe_playthrough ___________________________________

    def test_tic_tac_toe_playthrough():
>       envs = open_spiel_env._register_open_spiel_envs(["tic_tac_toe"])
E       AttributeError: module 'open_spiel.open_spiel' has no attribute '_register_open_spiel_envs'

kaggle_environments/envs/open_spiel/test_open_spiel.py:12: AttributeError
========================================= warnings summary =========================================

Copy link
Member

@bovard bovard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bovard bovard merged commit 43a86ee into Kaggle:master Jun 16, 2025
1 check passed
@jhtschultz jhtschultz deleted the add-uis-pr-ready branch June 23, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants