Merge pull request #530 from Kaggle/fix-hmr

Fix HMR import.meta lookups

Author: develra

kaggle_environments/envs/connectx/visualizer/default/package.json

@@ -4,8 +4,8 @@
   "version": "0.0.0",
   "type": "module",
   "scripts": {
-    "dev": "cross-env VITE_REPLAY_FILE=./replays/test-replay.json vite",
-    "dev:iframe": "vite",
+    "dev": "vite",
+    "dev-with-replay": "cross-env VITE_REPLAY_FILE=./replays/test-replay.json vite",
     "build": "tsc && vite build",
     "preview": "vite preview"
   },

kaggle_environments/envs/connectx/visualizer/default/src/main.ts

@@ -11,7 +11,7 @@ if (!app) {
 const adapter = new PreactAdapter(Renderer as any);
 if (app) {
   // Set up an HMR boundary for development
-  if (import.meta?.env?.DEV && import.meta?.hot) {
+  if (import.meta.env?.DEV && import.meta.hot) {
     import.meta.hot.accept();
   }
   createReplayVisualizer(app, adapter);

kaggle_environments/envs/open_spiel_env/games/repeated_poker/visualizer/default/src/main.ts

@@ -32,8 +32,9 @@ class LegacyAdapter implements GameAdapter {
 const app = document.getElementById('app');
 if (app) {
   // Set up an HMR boundary for development
-  if (import.meta?.env?.DEV && import.meta?.hot) {
+  if (import.meta.env?.DEV && import.meta.hot) {
     import.meta.hot.accept();
   }
+
   createReplayVisualizer(app, new LegacyAdapter());
 }

web/core/src/player.ts

@@ -277,18 +277,6 @@ export class ReplayVisualizer {
     this.stepSlider.max = (this.replay.steps.length > 0 ? this.replay.steps.length - 1 : 0).toString();
     this.renderControls();
 
-    // If we have steps but no agents, don't try to render.
-    // The player will wait until agents are provided (e.g., via postMessage)
-    // and handleMessage calls setData again.
-    if (this.replay && this.replay.steps.length > 0 && (!this.agents || this.agents.length === 0)) {
-      console.warn('setData: Have replay data, but no agents. Skipping render and waiting for agents.');
-      // Optionally update the viewer to show we're waiting
-      if (!options.skipRender) {
-        this.viewer.innerHTML = '<div>Replay loaded, waiting for agent data...</div>';
-      }
-      return;
-    }
-
     // Only render/tick if not told to skip (e.g., during HMR restore)
     if (!options.skipRender) {
       this.adapter.render(this.step, this.replay, this.agents);

web/core/src/replay-visualizer-factory.ts

@@ -16,15 +16,15 @@ interface ReplayVisualizerState {
 let hmrReplayVisualizerStates: Map<string, ReplayVisualizerState>;
 let hmrReplayVisualizerInstances: Map<string, ReplayVisualizer>;
 
-if (import.meta?.env?.DEV && import.meta?.hot) {
+if (import.meta.env?.DEV && import.meta.hot) {
   // 2. Initialize or retrieve the persistent state Map
-  if (!import.meta?.hot?.data?.replayVisualizerStates) {
+  if (!import.meta.hot?.data?.replayVisualizerStates) {
     import.meta.hot.data.replayVisualizerStates = new Map<string, ReplayVisualizerState>();
   }
-  hmrReplayVisualizerStates = import.meta?.hot?.data?.replayVisualizerStates;
+  hmrReplayVisualizerStates = import.meta.hot?.data?.replayVisualizerStates;
 
   // 3. Initialize or retrieve the instance Map (for cleanup)
-  if (!import.meta?.hot?.data?.replayVisualizerInstances) {
+  if (!import.meta.hot?.data?.replayVisualizerInstances) {
     import.meta.hot.data.replayVisualizerInstances = new Map<string, ReplayVisualizer>();
   }
   hmrReplayVisualizerInstances = import.meta.hot.data.replayVisualizerInstances;
@@ -41,7 +41,7 @@ if (import.meta?.env?.DEV && import.meta?.hot) {
  */
 export function createReplayVisualizer(container: HTMLElement, adapter: GameAdapter): ReplayVisualizer {
   // --- Production Build ---
-  if (!import.meta?.env?.DEV || !import.meta?.hot) {
+  if (!import.meta.env?.DEV || !import.meta.hot) {
     return new ReplayVisualizer(container, adapter);
   }