#38 - ApiController gets ignored when using [FromServices] Attribute on route

ky-one · ky-one · commit bf743d0ab5b2 · 2021-06-13T02:12:29.000+02:00
diff --git a/AspDotNet/Readers/AspDotNetControllerReader.cs b/AspDotNet/Readers/AspDotNetControllerReader.cs
@@ -52,7 +52,7 @@ public virtual void Read(AspDotNetReadConfiguration configuration, List<ITransfe
                 {
                     continue;
                 }
-                
+
                 List<Attribute> methodAttributes = method.GetCustomAttributes().ToList();
                 Dictionary<HttpServiceActionTypeTransferObject, string> actionTypes = this.GetActionTypes(methodAttributes);
                 if (actionTypes.Count == 0)
@@ -102,7 +102,7 @@ public virtual void Read(AspDotNetReadConfiguration configuration, List<ITransfe
                     action.ReturnType = returnType.ToTransferObject();
                     action.Route = actionType.Value ?? fallbackRoute;
                     action.Type = actionType.Key;
-                    ParameterInfo[] parameters = method.GetParameters();
+                    ParameterInfo[] parameters = method.GetParameters().Where(parameter => parameter.GetCustomAttributes().All(attribute => attribute.GetType().Name != "FromServicesAttribute")).ToArray();
                     foreach (ParameterInfo parameter in parameters)
                     {
                         this.modelReader.Read(parameter.ParameterType, transferObjects);

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public virtual void Read(AspDotNetReadConfiguration configuration, List<ITransfe`
`52`	`52`	`{`
`53`	`53`	`continue;`
`54`	`54`	`}`
`55`		`-`
	`55`	`+`
`56`	`56`	`List<Attribute> methodAttributes = method.GetCustomAttributes().ToList();`
`57`	`57`	`Dictionary<HttpServiceActionTypeTransferObject, string> actionTypes = this.GetActionTypes(methodAttributes);`
`58`	`58`	`if (actionTypes.Count == 0)`
`@@ -102,7 +102,7 @@ public virtual void Read(AspDotNetReadConfiguration configuration, List<ITransfe`
`102`	`102`	`action.ReturnType = returnType.ToTransferObject();`
`103`	`103`	`action.Route = actionType.Value ?? fallbackRoute;`
`104`	`104`	`action.Type = actionType.Key;`
`105`		`- ParameterInfo[] parameters = method.GetParameters();`
	`105`	`+ ParameterInfo[] parameters = method.GetParameters().Where(parameter => parameter.GetCustomAttributes().All(attribute => attribute.GetType().Name != "FromServicesAttribute")).ToArray();`
`106`	`106`	`foreach (ParameterInfo parameter in parameters)`
`107`	`107`	`{`
`108`	`108`	`this.modelReader.Read(parameter.ParameterType, transferObjects);`