Skip to content

Commit ad4c09c

Browse files
committed
Angular
- fix method with nullable date parameters ASP.NET - fix read nullable parameter as optional
1 parent a0ec95e commit ad4c09c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Angular/Writers/AngularServiceWriter.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ private void AddAppendDateMethod(ClassTemplate classTemplate)
722722
);
723723
classTemplate.AddMethod("appendDate", Code.Type("string")).Private()
724724
.WithParameter(Code.Type("string"), "url")
725-
.WithParameter(Code.Type("Date"), "date")
725+
.WithParameter(Code.Type("Date | null | undefined | string"), "date")
726726
.WithParameter(Code.Type("string"), "parameterName", Code.String(string.Empty))
727727
.WithParameter(Code.Type("string"), "separator", Code.String(string.Empty))
728728
.WithCode(Code.Return(Code.This().Method("append", Code.Local("url"), code, Code.Local("parameterName"), Code.Local("separator"))));

AspDotNet/Readers/AspDotNetControllerReader.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public virtual void Read(AspDotNetReadConfiguration configuration)
128128
actionParameter.FromQuery = parameterOptions.IsFromQuery;
129129
actionParameter.Inline = fullRoute.Contains($"{{{parameter.Name}}}");
130130
actionParameter.InlineIndex = actionParameter.Inline && action.Route != null ? action.Route.IndexOf($"{{{parameter.Name}}}") : 0;
131-
actionParameter.IsOptional = parameter.IsOptional;
131+
actionParameter.IsOptional = parameter.IsOptional || Nullable.GetUnderlyingType(parameter.ParameterType) != null;
132132
if (fullRoute.Contains($"{{{parameter.Name}?}}"))
133133
{
134134
actionParameter.Inline = true;

0 commit comments

Comments
 (0)