Angular

 - remove unnecessary instance creation on services

Author: ky-one

Angular/Writers/AngularServiceWriter.cs

@@ -86,37 +86,13 @@ public virtual void Write(AngularWriteConfiguration configuration, List<ITransfe
                     List<HttpServiceActionParameterTransferObject> urlDirectParameters = action.Parameters.Where(x => !x.FromBody && !x.Inline && !x.AppendName).ToList();
                     uri = urlParameters.Count > 0 ? $"{uri}?{urlParameters.First().Name}=" : urlDirectParameters.Count > 0 ? $"{uri}?" : uri;
                     MultilineCodeFragment code = Code.Multiline();
-                    DeclareTemplate declareTemplate = null;
                     bool hasReturnType = returnType.Name != "void";
-                    bool isPrimitive = this.IsPrimitive(returnType);
-                    if (returnType.Name == "Array")
+                    ExecuteMethodTemplate nextMethod = Code.Local("subject").Method("next");
+                    if (hasReturnType)
                     {
-                        TypeTemplate type = ((GenericTypeTemplate)returnType).Types[0];
-                        ICodeFragment createModelCode = isPrimitive
-                                                            ? (ICodeFragment)Code.Cast(type, Code.Local("entry"))
-                                                            : Code.InlineIf(Code.Local("entry").Equals().ForceNull().Or().Local("entry").Equals().Undefined(),
-                                                                            Code.Undefined(),
-                                                                            Code.New(type, Code.Local("entry"))
-                                                            );
-                        declareTemplate = Code.Declare(returnType, "list", Code.TypeScript("[]")).Constant();
-                        code.AddLine(declareTemplate)
-                            .AddLine(Code.TypeScript("for (const entry of result) {").BreakLine() /*.StartBlock()*/)
-                            .AddLine(Code.Local(declareTemplate).Method("push", createModelCode).Close())
-                            //.AddLine(Code.TypeScript("").EndBlock());
-                            .AddLine(Code.TypeScript("}").BreakLine());
+                        nextMethod.WithParameter(Code.Local("result"));
                     }
-                    else if (hasReturnType)
-                    {
-                        ICodeFragment createModelCode = isPrimitive
-                                                            ? (ICodeFragment)Code.Cast(returnType, Code.Local("result"))
-                                                            : Code.InlineIf(Code.Local("result").Equals().ForceNull().Or().Local("result").Equals().Undefined(),
-                                                                            Code.Undefined(),
-                                                                            Code.New(returnType, Code.Local("result"))
-                                                            );
-                        declareTemplate = Code.Declare(returnType, "model", createModelCode).Constant();
-                        code.AddLine(declareTemplate);
-                    }
-                    code.AddLine(Code.Local("subject").Method("next").WithParameter(declareTemplate.ToLocal()).Close())
+                    code.AddLine(nextMethod.Close())
                         .AddLine(Code.Local("subject").Method("complete").Close());
                     ChainedCodeFragment parameterUrl = Code.This().Field(serviceUrlField);
                     if (inlineParameters.Count == 0)

Examples/Angular/src/app/services/values-core.service.ts

@@ -27,11 +27,7 @@ export class ValuesCoreService {
     public get(httpOptions: {} = undefined): Observable<string[]> {
         let subject = new Subject<string[]>();
         this.http.get<string[]>(this.serviceUrl + "/api/values", httpOptions).subscribe(result => {
-            const list: string[] = [];
-            for (const entry of result) {
-            list.push(<string>entry);
-            }
-            subject.next(list);
+            subject.next(result);
             subject.complete();
         }, error => subject.error(error));
         return subject;
@@ -40,8 +36,7 @@ export class ValuesCoreService {
     public get2(id: number, httpOptions: {} = undefined): Observable<Value> {
         let subject = new Subject<Value>();
         this.http.get<Value>(this.serviceUrl + "/api/values/" + id, httpOptions).subscribe(result => {
-            const model: Value = result === null || result === undefined ? undefined : new Value(result);
-            subject.next(model);
+            subject.next(result);
             subject.complete();
         }, error => subject.error(error));
         return subject;

Examples/AspDotNet/CoreApi/Controllers/ValuesController.cs

@@ -37,14 +37,14 @@ public void Put(int id, [FromBody] Value value)
         public void Delete(int id)
         { }
 
-        // GET api/check
+        // GET api/values/check
         [HttpGet("[action]")]
         public ActionResult Check()
         {
             return this.Ok();
         }
 
-        // GET api/checkinterface
+        // GET api/values/checkinterface
         [HttpGet("[action]")]
         public IActionResult CheckInterface()
         {