Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new producer function PUWeightROOT to calculate pileup reweighting by directly reading from ROOT histogram files, providing an alternative to the existing correctionlib JSON-based approach. The implementation is adapted from the TauFW framework and has been validated for 2024 pileup conditions.
Changes:
- Added
PUWeightROOTfunction to read pileup weights from ROOT files containing data and MC pileup distributions - Added function declaration in the header file
- Updated jsonpog-integration submodule reference
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/reweighting.cxx | Implements new PUWeightROOT function with histogram-based PU weight calculation and adds clarifying note about ZPtMass function usage |
| include/reweighting.hxx | Adds function declaration for the new PUWeightROOT producer |
| data/jsonpog-integration | Updates submodule commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 8 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
A new producer is introduced to read PU weights from ROOT files, instead of using correctionlib with JSONs. This is adapted from the TauFW framework and validated for 2024 PU.