Skip to content

PR-based workflow does not trigger CI on tag #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
omus opened this issue Jan 30, 2024 · 4 comments · Fixed by #44
Closed

PR-based workflow does not trigger CI on tag #20

omus opened this issue Jan 30, 2024 · 4 comments · Fixed by #44

Comments

@omus
Copy link
Member

omus commented Jan 30, 2024

Probably this issue again: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs

@omus
Copy link
Member Author

omus commented Apr 19, 2024

Noticed this issue again with the release of v1.2.0+2024a. I also noticed that CI didn't run on main due to a misconfiguration of ignored paths (fixed in #24). I did think that the path-ignore rule was also being applied to tags which would be problematic but:

When using the push and pull_request events, you can configure a workflow to run based on what file paths are changed. Path filters are not evaluated for pushes of tags.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

@omus
Copy link
Member Author

omus commented Feb 10, 2025

Still an issue with v1.4.0+2025a: https://github.com/JuliaTime/TZJData.jl/actions/runs/13251320847/workflow

@omus
Copy link
Member Author

omus commented Feb 11, 2025

I intended to leave this open until this is confirmed to be fixed in the next TZJData.jl release

@omus omus reopened this Feb 11, 2025
@omus
Copy link
Member Author

omus commented Mar 24, 2025

Confirmed that the workflows are working as intended as of v1.5.0+2025b

@omus omus closed this as completed Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant