Remove test_project_toml_formatting

It stands out from all other tests in Aqua in that it does not actually
deal with 'quality'. The benefit is tiny if there is one at all, at the
same time it is unreasonably compicated to implement and use right.

Author: fingolfin

CHANGELOG.md

@@ -31,6 +31,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - The docstring for `test_stale_deps` explains the situation with package extensions. ([#203](https://github.com/JuliaTesting/Aqua.jl/pull/203))
 - The logo of Aqua.jl has been updated. ([#128](https://github.com/JuliaTesting/Aqua.jl/pull/128))
 
+### Removed
+
+- `test_project_toml_formatting` has been removed.
+
 
 ## [0.7.3] - 2023-09-25
 

docs/src/index.md

@@ -84,7 +84,6 @@ using Aqua
     project_extras=true,
     stale_deps=(ignore=[:SomePackage],),
     deps_compat=(ignore=[:SomeOtherPackage],),
-    project_toml_formatting=true,
     piracy=false,
   )
 end

src/Aqua.jl

@@ -19,7 +19,6 @@ include("exports.jl")
 include("project_extras.jl")
 include("stale_deps.jl")
 include("deps_compat.jl")
-include("project_toml_formatting.jl")
 include("piracy.jl")
 include("persistent_tasks.jl")
 
@@ -34,7 +33,6 @@ Run following tests in isolated testset:
 * [`test_project_extras(testtarget)`](@ref test_project_extras)
 * [`test_stale_deps(testtarget)`](@ref test_stale_deps)
 * [`test_deps_compat(testtarget)`](@ref test_deps_compat)
-* [`test_project_toml_formatting(testtarget)`](@ref test_project_toml_formatting)
 * [`test_piracy(testtarget)`](@ref test_piracy)
 * [`test_persistent_tasks(testtarget)`](@ref test_persistent_tasks)
 
@@ -50,7 +48,6 @@ passed to `\$x` to specify the keyword arguments for `test_\$x`.
 - `project_extras = true`
 - `stale_deps = true`
 - `deps_compat = true`
-- `project_toml_formatting = true`
 - `piracy = true`
 - `persistent_tasks = true`
 """
@@ -62,7 +59,6 @@ function test_all(
     project_extras = true,
     stale_deps = true,
     deps_compat = true,
-    project_toml_formatting = true,
     piracy = true,
     persistent_tasks = true,
 )
@@ -96,11 +92,6 @@ function test_all(
             test_deps_compat(testtarget; askwargs(deps_compat)...)
         end
     end
-    @testset "Project.toml formatting" begin
-        if project_toml_formatting !== false
-            test_project_toml_formatting(testtarget; askwargs(project_toml_formatting)...)
-        end
-    end
     @testset "Piracy" begin
         if piracy !== false
             test_piracy(testtarget; askwargs(piracy)...)

src/project_toml_formatting.jl

@@ -14,7 +14,6 @@ Aqua.test_all(
     project_extras = false,
     stale_deps = false,
     deps_compat = false,
-    project_toml_formatting = false,
     piracy = false,
     persistent_tasks = false,
 )