Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start benchmarking #10

Open
milktrader opened this issue Nov 5, 2013 · 6 comments
Open

Start benchmarking #10

milktrader opened this issue Nov 5, 2013 · 6 comments

Comments

@milktrader
Copy link
Contributor

Besides the test suite, we should begin benchmarking that not only do we get the correct answer, but we get it fast.

@milktrader
Copy link
Contributor Author

I've included the test/data/benchmark.csv file, which includes over 15,850 rows of data. Not sure if this is big enough for benchmarking. I think that taking simple returns of the Close for example would give a nice array to time functions on.

@milktrader
Copy link
Contributor Author

We should follow the layout that DataFrames has for this, which is similar to how unit testing is done.

@rob-luke
Copy link
Contributor

Is there a way to automatically run @time or other benchmarking tools automatically via travis or some other CI on original and changed code? So you can see if a pull request will provide performance improvements.

@rob-luke
Copy link
Contributor

The Benchmark package looks nice. But I see no easy way to compare against different git commits.

@andreasnoack
Copy link
Member

Such functionality is actively being worked on right now so hopefully it'll be availiable within a couple of months.

@rob-luke
Copy link
Contributor

Thanks. Is there a conversation somewhere I can follow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants