-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IERS data format change #101
Comments
Hi @ThatcherC ! Thanks for the report! Sure! I think it will be very important to backport to v0.9. |
Awesome! I've got a super quick PR here - JuliaSpace/SatelliteToolboxTransformations.jl#3 |
I will merge your PR as soon the tests finish. After that, I will back port the fix and tag a new v0.9. |
Awesome! Thanks for reviewing so quickly! And any chance it could also be backported to v0.10? I realized I have a few programs that pinned that version as well. |
No problem! Let's do this :) |
Hi @ThatcherC ! Sorry for the delay! I tagged v0.1.5 of SatelliteToolboxTransformations.jl, and v0.9.5 and v0.10.1 of SatelliteToolbox.jl, which should add the support for the new format in all the ecosystem :) Please, let me know if everything is working. Thank you again for the report and the fix! |
Awesome! Thank you @ronisbr! I've updated all my programs and they're working great with v0.9.5 and v0.10.1! Thanks for the speedy backport! Here's hoping they don't change the IERS format again any time soon! |
I haven't been able to ingest IERS EOP parameters today:
This is with SatelliteToolbox v0.10.0 - I've been using that because the new versions break some functions I use in my existing programs.
I can confirm that the issue affects SatelliteToolbx v0.12.0 too though -
Turns out there was an announcement about this that I missed! https://datacenter.iers.org/data/2/message_490.txt
The start of the message explains why we are seeing this issue - new columns have been added to the CSV:
Looks like the IERS fetching code needs to fixed! I'll probably put together a draft this afternoon and send it out. Is there any chance we can backport the change to older versions? I'm using v0.9.4 in and it'd be great if I could get the fix into that program without updating that program to the new SatelliteToolbox API.
The text was updated successfully, but these errors were encountered: