Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] DynamicQuantities.jl extension #5067

Open
Ickaser opened this issue Mar 28, 2025 · 3 comments
Open

[FR] DynamicQuantities.jl extension #5067

Ickaser opened this issue Mar 28, 2025 · 3 comments

Comments

@Ickaser
Copy link

Ickaser commented Mar 28, 2025

It would be lovely to have an extension like the existing Unitful extension for DynamicQuantities.jl, and I suspect that I could achieve that myself by copying the Unitful extension with some minor modifications to accommodate the differences in how DynamicQuantities handles things. Before I commit to that, though, I am curious if anyone (@gustaphe?) is seriously planning an overhaul of the unit handling for 2.0, in which case I would probably prefer to contribute some effort to that first.

@gustaphe
Copy link
Collaborator

When you say 2.0 do you mean Plots.jl 2.0?

I had not planned anything, but I might be out of the loop. Should I be?

As for copying the extension, perhaps it would be simpler and more robust to simply convert to Unitful quantities in the recipe? That way any future improvements to the extension work for both packages.

@Ickaser
Copy link
Author

Ickaser commented Apr 1, 2025

I do mean Plots.jl 2.0.

I had seen your comment in #4822 (comment) , and there are similar issues at #4741, #4750; plus #4453 would be nice.

The suggestion to map from DQ to Unitful would mean adding Unitful as a dependency of the extension, which seems weird and maybe difficult since DQ is probably the lighter package of the two; some things don't have one-to-one analogs and the extension namespace might be complicated, but if the dependency question has an easy answer then it would make sense to keep features in lockstep I think

@gustaphe
Copy link
Collaborator

gustaphe commented Apr 2, 2025

It's maybe a question of measuring the impact of the packages - my feeling is that someone using DQ upon loading Plots will notice the impact of Plots, but not necessarily the impact of Unitful, but I always load both so maybe I don't know.
The really robust way to do this would be to have a lightweight common ground, but I'm not volunteering to write it.

I say give it a try. If you need to discuss something or if you figure out something we want for the Unitful extension, do let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants