Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ObjectFile dependency #1307

Closed
eschnett opened this issue Dec 13, 2023 · 6 comments · Fixed by #1316
Closed

Update ObjectFile dependency #1307

eschnett opened this issue Dec 13, 2023 · 6 comments · Fixed by #1316

Comments

@eschnett
Copy link
Contributor

BinaryBuilder.jl depends on ObjectFile = "0.3.6". This conflicts with Metal.jl which requires ObjectFile = "0.4". Could this dependency be updated? The latest version is 0.4.1.

@giordano
Copy link
Member

There is #1277 already, but tests are broken and I don't know why. I don't know what changed in the ObjectFile package.

@eschnett
Copy link
Contributor Author

@giordano How do I see which tests are broken? There doesn't seem to be any Github CI tests.

@staticfloat Do you know what changed in ObjectFile.jl between 0.3.7 and 0.4.1?

@giordano
Copy link
Member

@giordano How do I see which tests are broken? There doesn't seem to be any Github CI tests.

I think I ran the tests locally.

@giordano
Copy link
Member

I'm moderately sure it was JuliaIO/ObjectFile.jl#38 which broke it (the minor version number was bumped there), it changed the API of some commands, but never tracked how.

@eschnett
Copy link
Contributor Author

Can we create a new release with the by-now updated ObjectFile dependency?

@eschnett
Copy link
Contributor Author

@giordano Can we release a new version of this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants