Skip to content

Use public via Meta.parse for Julia 1.10 compatibility #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2025

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Apr 3, 2025

  • Remove simple @public macro
  • Support early development versions of Julia 1.11
  • Use eval(Meta.parse(...))

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3655020). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage        ?   91.64%           
=======================================
  Files           ?       28           
  Lines           ?     1185           
  Branches        ?        0           
=======================================
  Hits            ?     1086           
  Misses          ?       99           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well remove @static everywhere then.

The number if areas where @static seems to decreasing.

While I acknowledge that @static is not required here, I am unsure it lacks no utility.

Certainly VERSION is known at parse time. I'm unclear if relieving early Julia versions of having to evaluate the if statement during precompilation has any material impact or not.

Co-authored-by: Mark Kittisopikul <[email protected]>
@nhz2
Copy link
Member

nhz2 commented Apr 3, 2025

This looks good. I prefer having all the imports, exports, and publics in the main file instead of a separate public.jl file.

I'll make a new release once I add a few other clean-ups for the URL change and to fix PkgEval.

@nhz2 nhz2 merged commit 15cedc8 into JuliaIO:main Apr 3, 2025
43 checks passed
@mkitti
Copy link
Member Author

mkitti commented Apr 3, 2025

It might be good to introduce Julia 1.10 into CI as in #31. However, this will probably be easier to get working after you finish registering the new package versions and perhaps ChunkCodecTests.

@mkitti
Copy link
Member Author

mkitti commented Apr 4, 2025

@bjarthur these packages should work with Julia 1.10 LTS now upon release.

I'm still thinking of moving forward with something like JuliaIO/Zarr.jl#183 although the need is less now.

cc: @StephanPreibisch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants