-
Notifications
You must be signed in to change notification settings - Fork 1
Use public via Meta.parse for Julia 1.10 compatibility #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage ? 91.64%
=======================================
Files ? 28
Lines ? 1185
Branches ? 0
=======================================
Hits ? 1086
Misses ? 99
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Lilith Orion Hafner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might as well remove @static
everywhere then.
The number if areas where @static
seems to decreasing.
While I acknowledge that @static
is not required here, I am unsure it lacks no utility.
Certainly VERSION
is known at parse time. I'm unclear if relieving early Julia versions of having to evaluate the if statement during precompilation has any material impact or not.
Co-authored-by: Mark Kittisopikul <[email protected]>
This looks good. I prefer having all the imports, exports, and publics in the main file instead of a separate I'll make a new release once I add a few other clean-ups for the URL change and to fix PkgEval. |
It might be good to introduce Julia 1.10 into CI as in #31. However, this will probably be easier to get working after you finish registering the new package versions and perhaps ChunkCodecTests. |
@bjarthur these packages should work with Julia 1.10 LTS now upon release. I'm still thinking of moving forward with something like JuliaIO/Zarr.jl#183 although the need is less now. |
@public
macroeval(Meta.parse(...))