Address code review

Author: asinghvi17

src/utils/UnitSpherical/cap.jl

@@ -25,18 +25,17 @@ SphericalCap(t::GI.PointTrait, geom) = SphericalCap(t, geom, 0)
 # TODO: exact-predicate intersection
 # This is all inexact and thus subject to floating point error
 function _intersects(x::SphericalCap, y::SphericalCap)
-    spherical_distance(x.point, y.point) <= max(x.radius, y.radius)
+    spherical_distance(x.point, y.point) <= x.radius + y.radius
 end
 
 _disjoint(x::SphericalCap, y::SphericalCap) = !_intersects(x, y)
 
 function _contains(big::SphericalCap, small::SphericalCap)
     dist = spherical_distance(big.point, small.point)
-    return dist < big.radius #=small.point in big=# && 
-            dist + small.radius < big.radius # small circle fits in big circle
+    # small circle fits in big circle
+    return dist + small.radius < big.radius 
 end
 
-
 function circumcenter_on_unit_sphere(a::UnitSphericalPoint, b::UnitSphericalPoint, c::UnitSphericalPoint)
     LinearAlgebra.normalize(a × b + b × c + c × a)
 end

src/utils/UnitSpherical/point.jl

@@ -125,8 +125,8 @@ spherical_distance(x::UnitSphericalPoint, y::UnitSphericalPoint) = acos(clamp(x
 # ## Random points
 Random.rand(rng::Random.AbstractRNG, ::Random.SamplerType{UnitSphericalPoint}) = rand(rng, UnitSphericalPoint{Float64})
 function Random.rand(rng::Random.AbstractRNG, ::Random.SamplerType{UnitSphericalPoint{T}}) where T <: Number
-    θ = 2π * rand(rng, T)
-    ϕ = acos(2 * rand(rng, T) - 1)
+    ϕ = 2π * rand(rng, T)
+    θ = acos(2 * rand(rng, T) - 1)
     sinθ, cosθ = sincos(θ)
     sinϕ, cosϕ = sincos(ϕ)
     return UnitSphericalPoint(