Variable as a disk array #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @rafaqz, thank you, it sounds good to me! |
tcarion
approved these changes
Mar 7, 2025
|
Oh I think there are a few minor changes to push, wasn't aware the tests had started passing! |
|
Ok should be good to merge |
|
Can we get a new patch version? |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DiskArrays methods to
Variableso thatreadblock!etc don't fail on it as they do currently.I'm aware that we are not currently passing the chunk pattern of the messages to DiskArrays.jl so this wont have much useful affect excepet API compatability, but its a start.
After this broadcasts and reductions are much faster. This may be a nice template for making AbastractVariable a DiskArray.
Failures are waiting on a version of DiskArrays