Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TimeSeriesIO dependency #23

Open
femtotrader opened this issue Jul 10, 2017 · 2 comments
Open

Remove TimeSeriesIO dependency #23

femtotrader opened this issue Jul 10, 2017 · 2 comments
Labels

Comments

@femtotrader
Copy link
Collaborator

femtotrader commented Jul 10, 2017

femtotrader/TimeSeriesIO.jl#19

Most of data/table like could be output using https://github.com/davidanthoff/IterableTables.jl

TimeSeriesIO dependency can be removed in favor of IterableTables.jl which support several different data structures.

Require may also (or not) be considered
https://discourse.julialang.org/t/optional-dependencies-requires-jl/3294/5

@Pankaj-Baranwal
Copy link

I have started working on this issue.
Here is my approach:
google/daily.jl contains a function TimeArray.
I will replace it with IterableTables' TimeSeries.jl

Is this okay?

@s-celles
Copy link

Several approaches are possible.

using directly TimeArray from TimeSeries will involve to add TimeSeries.jl as a dependency.

For now TimeSeries is currently required by DataReaders.jl

TimeSeries

but it's probably not a good idea... because such an approach won't work if we want to add support for several kind of datastructures (IndexedTables, Temporal TS...) as this package will have too much dependencies.

I think it's better to require IterableTables than TimeSeries

For datastructures that are not supported currently by IterableTables (NamedArrays for example), using Requires.jl will be necessary to have optional dependencies.

But you can try both approach and see pros and cons.

I'm really open about implementation but I would prefer not to have too much dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants