Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package when Base.delete is defined #12

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

KristofferC
Copy link
Contributor

Base.delete does not define all the methods required for this package so we still need to define them.

@Tokazama
Copy link
Member

I think when I originally added this there were several PRs moving towards adding similar functionality, so I thought its relevance was more imminent. I haven't really been following that for a while though. Is the idea here to just treat these methods as a feature of this package instead of something that may be overloaded from base in the future?

@KristofferC
Copy link
Contributor Author

It just fixes the tests on 1.11. The assumptions on what Base.delete provides is at least currently faulty in the package.

@Tokazama Tokazama merged commit d4e4af0 into JuliaCollections:master Apr 25, 2024
6 checks passed
@Tokazama
Copy link
Member

Thanks for the help. I merged it and added a note to the commit so that anyone that looks at the code here can see what's going if there needs to be more bikeshedding or bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants