Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default compare against the base of the branch #153

Closed
IanButterworth opened this issue Nov 16, 2022 · 1 comment
Closed

Make default compare against the base of the branch #153

IanButterworth opened this issue Nov 16, 2022 · 1 comment

Comments

@IanButterworth
Copy link
Member

Currently pkgeval runs are done specifying vs = :master, which means that master may have deviated from the base of the branch where the commit being evaluated resides, making comparison hard given how frequently master changes.

@KristofferC suggested to make the default where no vs is specified compare against the base of the branch.

@giordano showed this is how the base is grabbed in yggrasil https://github.com/JuliaPackaging/Yggdrasil/blob/33f7cbd4ba0e4789fef6b20cb4ee15532b24331c/azure-pipelines.yml#L40
@maleadt
Copy link
Member

maleadt commented Nov 18, 2022

JuliaCI/Nanosoldier.jl#134

@maleadt maleadt closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maleadt @IanButterworth