Skip to content

Switch to BinaryBuilder.jl #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ranocha opened this issue Apr 3, 2022 · 7 comments
Closed

Switch to BinaryBuilder.jl #170

ranocha opened this issue Apr 3, 2022 · 7 comments

Comments

@ranocha
Copy link

ranocha commented Apr 3, 2022

Would you consider switching to BinaryBuilder.jl? We experienced problems with new Apple M1 devices due to the build script of FastTransforms.jl, see trixi-framework/Trixi.jl#1104 (comment)

CC @sloede

@MikaelSlevinsky
Copy link
Member

FastTransforms.jl has FastTransforms_jll.jl with binaries for M1 Macs. The BinaryProvider route is only for developer support to allow compiling from source.

Maybe it's that the build script always gets invoked and it sees that it's using BinaryProvider for some diagnostic functions?

@sloede
Copy link

sloede commented Apr 4, 2022

That's possible. I am not sure how the underlying mechanisms work, but if I try to run tests on an M1 Mac that have FastTransforms as a dependency, this error is invoked. Is there any way that the using is only invoked if really necessary?

@MikaelSlevinsky
Copy link
Member

Tagging a new minor release based on this 4bbefc9. Probably will work for you, but let me know if it doesn't.

@sloede
Copy link

sloede commented Apr 4, 2022

Thank you for looking into it. Unfortunately, it does not solve all issues. Here I tried adding FastTransforms.jl in a temporary project:
image

Weirdly enough, it says precompilation succeeded, but also that it didn't. Maybe the issue is, that BinaryProvider.jl is still in the dependency list in Project.toml?

@MikaelSlevinsky
Copy link
Member

This ought to do it ee31e98.

@sloede
Copy link

sloede commented Apr 4, 2022

Great, thanks! I can confirm that with v0.13.9, FastTransforms.jl works on the M1. Kudos for the fast response & fix!

@ranocha
Copy link
Author

ranocha commented Apr 4, 2022

I can only second that - thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants