Add new WriteRecords benchmark and performance fix.

The new benchmark measures the performance of WriteRecords given an `IEnumerable<T>` records. The performance fix is to adjust `ObjectRecordWriter` to take all expressions and put them into a single block expression that writes all fields at once, instead of combining multiple expressions into a single multi-cast delegate. This results in fewer delegate invocations since it is called per record instead of per field, and only a single delegate compile. The current benchmark runs ~15% faster with the new code.

Now that delegates are not combined `RecordWriter.CombineDelegates` could be removed, though I opted not to since it is on a public class and I didn't want to break compatibility. I also noted this was added since Silverlight doesn't have `Delegate.Combine` and I'm not sure if Silverlight has `Expression.Block` though given it is out of support as of Oct 2021 I figured this was ok.

Author: Nik Karpinsky

performance/CsvHelper.Benchmarks/BenchmarkEnumerateRecords.cs

@@ -6,7 +6,6 @@
 
 namespace CsvHelper.Benchmarks;
 
-[MemoryDiagnoser]
 public class BenchmarkEnumerateRecords
 {
 	private const int entryCount = 10000;

performance/CsvHelper.Benchmarks/BenchmarkMain.cs

@@ -1,11 +1,18 @@
 using BenchmarkDotNet.Running;
+using BenchmarkDotNet.Configs;
+using BenchmarkDotNet.Jobs;
 
 namespace CsvHelper.Benchmarks;
 
 internal class BenchmarkMain
 {
 	static void Main(string[] args)
 	{
-		_ = BenchmarkRunner.Run<BenchmarkEnumerateRecords>();
+		BenchmarkSwitcher.FromAssembly(System.Reflection.Assembly.GetExecutingAssembly()).Run(
+			args,
+			DefaultConfig.Instance
+				.AddJob(BenchmarkDotNet.Jobs.Job.Default.WithEnvironmentVariables(System.Array.Empty<BenchmarkDotNet.Jobs.EnvironmentVariable>()).AsMutator())
+				.AddDiagnoser(new Microsoft.VSDiagnostics.CPUUsageDiagnoser())
+		); return;
 	}
 }

performance/CsvHelper.Benchmarks/BenchmarkWriteCsv.cs

@@ -0,0 +1,55 @@
+using System;
+using System.Collections.Generic;
+using System.Globalization;
+using System.IO;
+using BenchmarkDotNet.Attributes;
+
+namespace CsvHelper.Benchmarks;
+
+public class BenchmarkWriteCsv
+{
+	private const int entryCount = 10000;
+	private readonly List<Simple> records = new(entryCount);
+	
+	public class Simple
+	{
+		public int Id1 { get; set; }
+		public int Id2 { get; set; }
+		public string Name1 { get; set; }
+		public string Name2 { get; set; }
+	}
+
+	[GlobalSetup]
+	public void GlobalSetup()
+	{
+		var random = new Random(42);
+		var chars = new char[10];
+		string getRandomString()
+		{
+			for (int i = 0; i < 10; ++i)
+				chars[i] = (char)random.Next('a', 'z' + 1);
+			return new string(chars);
+		}
+
+		for (int i = 0; i < entryCount; ++i)
+		{
+			records.Add(new Simple
+			{
+				Id1 = random.Next(),
+				Id2 = random.Next(),
+				Name1 = getRandomString(),
+				Name2 = getRandomString(),
+			});
+		}
+	}
+
+	[Benchmark]
+	public void WriteRecords()
+	{
+		using var stream = new MemoryStream();        
+		using var streamWriter = new StreamWriter(stream);
+		using var writer = new CsvHelper.CsvWriter(streamWriter, CultureInfo.InvariantCulture);
+		writer.WriteRecords(records);
+		streamWriter.Flush();
+	}
+}

performance/CsvHelper.Benchmarks/CsvHelper.Benchmarks.csproj

@@ -6,7 +6,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="BenchmarkDotNet" Version="0.15.0" />
+    <PackageReference Include="BenchmarkDotNet" Version="0.15.2" />
+    <PackageReference Include="Microsoft.VisualStudio.DiagnosticsHub.BenchmarkDotNetDiagnosers" Version="18.0.36328.1" />
   </ItemGroup>
 
   <ItemGroup>

src/CsvHelper/Expressions/ObjectRecordWriter.cs

@@ -46,7 +46,7 @@ protected override Action<T> CreateWriteDelegate<T>(Type type)
 			throw new WriterException(Writer.Context, $"No properties are mapped for type '{type.FullName}'.");
 		}
 
-		var delegates = new List<Action<T>>();
+		var expressions = new List<Expression>(members.Count);
 
 		foreach (var memberMap in members)
 		{
@@ -59,7 +59,7 @@ protected override Action<T> CreateWriteDelegate<T>(Type type)
 				var args = Expression.New(constructor, recordParameterConverted);
 				Expression exp = Expression.Invoke(memberMap.Data.WritingConvertExpression, args);
 				exp = Expression.Call(Expression.Constant(Writer), nameof(Writer.WriteField), null, exp);
-				delegates.Add(Expression.Lambda<Action<T>>(exp, recordParameter).Compile());
+				expressions.Add(exp);
 				continue;
 			}
 
@@ -110,12 +110,16 @@ protected override Action<T> CreateWriteDelegate<T>(Type type)
 			}
 
 			var writeFieldMethodCall = Expression.Call(Expression.Constant(Writer), nameof(Writer.WriteConvertedField), null, fieldExpression, Expression.Constant(memberMap.Data.Type));
-
-			delegates.Add(Expression.Lambda<Action<T>>(writeFieldMethodCall, recordParameter).Compile());
+			expressions.Add(writeFieldMethodCall);
 		}
 
-		var action = CombineDelegates(delegates) ?? new Action<T>((T parameter) => { });
+		if (expressions.Count == 0)
+		{
+			return new Action<T>((T parameter) => { });
+		}
 
-		return action;
+		// Combine all field writes into a single block
+		var block = Expression.Block(expressions);
+		return Expression.Lambda<Action<T>>(block, recordParameter).Compile();
 	}
 }